Merge pull request #83 from rtCamp/ui-fixes

feat: Ui update to frappe ui v1.0.0

Author: trufurs

.gitignore

@@ -3,6 +3,7 @@
 *.egg-info
 *.swp
 __pycache__
+.ruff_cache
 dev-dist
 tags
 node_modules

README.md

@@ -308,7 +308,6 @@ crm_sidebar = [
     {
         "label": "Procurement",
         "type": "group",
-        "icon": "package",
         "items": [
             {
                 "label": "Suppliers",
@@ -335,7 +334,7 @@ crm_sidebar = [
 | `type` | `str` | ✅ | `"list_view"`, `"route"`, `"separator"`, or `"group"` |
 | `doctype` | `str` | `list_view` only | Frappe DocType to display |
 | `url` | `str` | `route` only | Destination URL |
-| `icon` | `str` | — | [Lucide](https://lucide.dev/icons/) icon name (default: `"list"`) |
+| `icon` | `str` | — | [Lucide](https://lucide.dev/icons/) icon name (default: `"list"`). Not supported on `group` — FCRM section headers are chevron + text only |
 | `default_filters` | `dict` | — | Pre-applied filters; users can see and clear them |
 | `hidden_filters` | `dict` | — | Always-applied filters; never shown in the UI |
 | `fields` | `list[str]` | — | Column order override; title and Modified are always included |

frappe_crm_xt/__init__.py

@@ -1 +1 @@
-__version__ = "1.1.1"
+__version__ = "1.2.0"

frappe_crm_xt/fixtures/crm_form_script.json

@@ -105,6 +105,9 @@
 #       Destination URL, e.g. "/app/purchase-order" or "https://example.com"
 #
 #   icon           (str, optional)  Lucide icon name (default: "list")
+#       Not supported on type == "group": FCRM section headers are chevron +
+#       text only (frappe-ui SidebarLabel has no icon slot), so a group icon
+#       would be the one header in the sidebar that looks different.
 #       Any of the 1600+ Lucide icon names work — see https://lucide.dev/icons/
 #       Common examples: users, user, briefcase, file-text, package,
 #         shopping-cart, tag, inbox, phone, calendar, square-check,
@@ -174,7 +177,6 @@
 #     {
 #         "label": "Procurement",     # ── collapsible group ───────────────────
 #         "type": "group",
-#         "icon": "package",
 #         "items": [
 #             {
 #                 "label": "Suppliers",
@@ -198,7 +200,6 @@
 	{
 		"label": "List Views",
 		"type": "group",
-		"icon": "layout-grid",
 		"items": [
 			{
 				"label": "Reports",
@@ -214,7 +215,7 @@
 				"type": "list_view",
 				"doctype": "CRM Lead",
 				"icon": "users",
-				"fields": ["name", "lead_name", "organization", "status", "creation"],
+				"fields": ["name", "title", "organization", "status", "creation"],
 				"default_filters": {"converted": ["=", "1"]},
 				"row_url": "/crm/leads/{name}",
 			},

frappe_crm_xt/hooks.py

@@ -9,3 +9,4 @@ frappe_crm_xt.patches.v1_0.reset_fcrm_note_modified_to_creation
 frappe_crm_xt.patches.v1_0.setup_global_search_for_crm_doctypes #rerun to add CRM Organization
 frappe_crm_xt.patches.v1_0.create_crm_slack_notifications
 frappe_crm_xt.patches.v1_0.relink_gmail_threads_to_converted_deals
+frappe_crm_xt.patches.v1_0.clear_calendar_field_descriptions

frappe_crm_xt/patches.txt

@@ -0,0 +1,24 @@
+import frappe
+
+FIELDNAMES = (
+	"custom_start_datetime",
+	"custom_sync_with_calendar",
+	"custom_google_calendar_link",
+)
+
+
+def execute():
+	names = frappe.get_all(
+		"Custom Field",
+		filters={
+			"dt": "CRM Task",
+			"fieldname": ["in", FIELDNAMES],
+			"description": ["is", "set"],
+		},
+		pluck="name",
+	)
+	if not names:
+		return
+
+	for name in names:
+		frappe.db.set_value("Custom Field", name, "description", "", update_modified=False)

frappe_crm_xt/patches/v1_0/clear_calendar_field_descriptions.py

@@ -422,8 +422,7 @@
       "fieldname": "custom_start_datetime",
       "fieldtype": "Datetime",
       "label": "Start Date & Time",
-      "insert_after": "due_date",
-      "description": "Start of the calendar event. Stored in the system timezone; shown in each user's own timezone."
+      "insert_after": "due_date"
     },
     {
       "fieldname": "custom_calendar_sync_section",
@@ -436,7 +435,6 @@
       "fieldname": "custom_sync_with_calendar",
       "fieldtype": "Check",
       "label": "Sync with Calendar",
-      "description": "When checked, a Frappe Event is created on this task and linked to your calendar.",
       "insert_after": "custom_calendar_sync_section"
     },
     {
@@ -453,8 +451,7 @@
       "label": "Google Calendar",
       "options": "Google Calendar",
       "insert_after": "custom_event_participants",
-      "depends_on": "eval:doc.custom_sync_with_calendar",
-      "description": "The connected Google Calendar to push this event to. The calendar must be authorized with Push enabled."
+      "depends_on": "eval:doc.custom_sync_with_calendar"
     }
   ],
   "CRM Deal Status": [