Rename sendBotListUpdateToObservers to sendBotListUpdateToObserversAndControllers and update relevant calls for better clarity.

flemming-n-larsen · flemming-n-larsen · commit 0e7ba106322f · 2025-08-25T20:55:55.000+02:00
diff --git a/server/src/main/kotlin/dev/robocode/tankroyale/server/core/GameServer.kt b/server/src/main/kotlin/dev/robocode/tankroyale/server/core/GameServer.kt
@@ -650,7 +650,8 @@ class GameServer(
         connectionHandler.broadcast(participants, json) // note: it is only participants, not all bots
     }
 
-    private fun sendBotListUpdateToObservers() {
+    // Note: Despite the name, this update is intended for both observers and controllers
+    private fun sendBotListUpdateToObserversAndControllers() {
         // Send a clone of the message to prevent race conditions if the message is updated during broadcast
         broadcastToObserverAndControllers(cloneBotListUpdate(botListUpdateMessage))
     }
@@ -669,7 +670,7 @@ class GameServer(
 
     internal fun handleBotJoined() {
         updateBotListUpdateMessage()
-        sendBotListUpdateToObservers()
+        sendBotListUpdateToObserversAndControllers()
     }
 
     internal fun handleBotLeft(conn: WebSocket) {
@@ -689,7 +690,7 @@ class GameServer(
         }
 
         updateBotListUpdateMessage()
-        sendBotListUpdateToObservers()
+        sendBotListUpdateToObserversAndControllers()
     }
 
     internal fun handleBotReady(conn: WebSocket) {

Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,8 @@ class GameServer(`
`650`	`650`	`connectionHandler.broadcast(participants, json) // note: it is only participants, not all bots`
`651`	`651`	`}`
`652`	`652`
`653`		`- private fun sendBotListUpdateToObservers() {`
	`653`	`+ // Note: Despite the name, this update is intended for both observers and controllers`
	`654`	`+ private fun sendBotListUpdateToObserversAndControllers() {`
`654`	`655`	`// Send a clone of the message to prevent race conditions if the message is updated during broadcast`
`655`	`656`	`broadcastToObserverAndControllers(cloneBotListUpdate(botListUpdateMessage))`
`656`	`657`	`}`
`@@ -669,7 +670,7 @@ class GameServer(`
`669`	`670`
`670`	`671`	`internal fun handleBotJoined() {`
`671`	`672`	`updateBotListUpdateMessage()`
`672`		`- sendBotListUpdateToObservers()`
	`673`	`+ sendBotListUpdateToObserversAndControllers()`
`673`	`674`	`}`
`674`	`675`
`675`	`676`	`internal fun handleBotLeft(conn: WebSocket) {`
`@@ -689,7 +690,7 @@ class GameServer(`
`689`	`690`	`}`
`690`	`691`
`691`	`692`	`updateBotListUpdateMessage()`
`692`		`- sendBotListUpdateToObservers()`
	`693`	`+ sendBotListUpdateToObserversAndControllers()`
`693`	`694`	`}`
`694`	`695`
`695`	`696`	`internal fun handleBotReady(conn: WebSocket) {`