BUG: fix UB - strides can be negative, so use signed types for stride… #30
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Tests | |
| on: | |
| push: | |
| branches: | |
| - v1.** | |
| - ci-asan | |
| pull_request: | |
| branches: | |
| - main | |
| - v1.** | |
| concurrency: | |
| # avoid duplicate runs on both pushes and PRs | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| cancel-in-progress: true | |
| env: | |
| # Coloured output for GitHub Actions | |
| FORCE_COLOR: 3 | |
| # Some common environment variables for both GNU/Linux and macOS jobs | |
| MPLBACKEND: Agg | |
| CYTHON_TRACE: 1 | |
| CYTHONSPEC: cython | |
| NUMPY_MIN: numpy==1.26.4 | |
| CYTHON_MIN: cython==3.1.3 | |
| jobs: | |
| clang_ASan_UBSan: | |
| name: Test under ASan and UBSan | |
| runs-on: macos-latest | |
| steps: | |
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| with: | |
| submodules: recursive | |
| fetch-tags: true | |
| persist-credentials: false | |
| - name: Set up pyenv | |
| run: | | |
| git clone https://github.com/pyenv/pyenv.git "$HOME/.pyenv" | |
| PYENV_ROOT="$HOME/.pyenv" | |
| PYENV_BIN="$PYENV_ROOT/bin" | |
| PYENV_SHIMS="$PYENV_ROOT/shims" | |
| echo "$PYENV_BIN" >> $GITHUB_PATH | |
| echo "$PYENV_SHIMS" >> $GITHUB_PATH | |
| echo "PYENV_ROOT=$PYENV_ROOT" >> $GITHUB_ENV | |
| - name: Set up LLVM | |
| run: | | |
| brew install llvm@19 | |
| LLVM_PREFIX=$(brew --prefix llvm@19) | |
| echo CC="$LLVM_PREFIX/bin/clang" >> $GITHUB_ENV | |
| echo CXX="$LLVM_PREFIX/bin/clang++" >> $GITHUB_ENV | |
| echo LDFLAGS="-L$LLVM_PREFIX/lib" >> $GITHUB_ENV | |
| echo CPPFLAGS="-I$LLVM_PREFIX/include" >> $GITHUB_ENV | |
| - name: Build Python with AddressSanitizer | |
| run: | | |
| CONFIGURE_OPTS="--with-address-sanitizer" pyenv install 3.14 | |
| pyenv global 3.14 | |
| - name: Install NumPy dependencies from PyPI | |
| run: | | |
| pip install meson-python ninja cython | |
| - name: Build NumPy with ASan | |
| run: | |
| pip install numpy --no-binary numpy --no-build-isolation -Csetup-args="-Db_sanitize=address" -v | |
| - name: Install dependencies from PyPI | |
| run: | | |
| pip install spin pytest pytest-timeout | |
| - name: Build PyWavelets with ASan and UBSan | |
| run: | | |
| export CFLAGS=-fno-sanitize=function # suppressed upstream, see cython#7437 | |
| spin build -- -Db_sanitize=address,undefined -Db_lundef=false | |
| - name: Test | |
| run: | | |
| # pass -s to pytest to see ASAN errors and warnings, otherwise pytest captures them | |
| ASAN_OPTIONS=detect_leaks=0:symbolize=1:strict_init_order=true:allocator_may_return_null=1:use_sigaltstack=0 \ | |
| UBSAN_OPTIONS=halt_on_error=1 \ | |
| spin test -- -v -s --timeout=600 --durations=10 |