Skip to content

fix_qfiledialog fails if call inside another function call #17

@lafrech

Description

@lafrech

PyQt4 code:

from PyQt4 import QtCore, QtGui

class Test(QtGui.QDialog):

    def set_filepath(self):
        self.filePathEdit.setText(
            QtGui.QFileDialog.getOpenFileName(
                self,
                "Choose file",
                self.filePathEdit.text()))

results in

from PyQt5 import QtCore, QtGui, QtWidgets

class Test(QtWidgets.QDialog):

    def set_filepath(self):
        self.filePathEdit.setText(
            QtWidgets.QFileDialog.getOpenFileName(
                self,
                "Choose file",
                self.filePathEdit.text()))[0]

See, the [0] should be before the last parenthesis.

        self.filePathEdit.setText(
            QtWidgets.QFileDialog.getOpenFileName(
                self,
                "Choose file",
                self.filePathEdit.text())[0])  # <--- here

Looks like an issue in find_closing_parenthesis.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions