Improved system model metarch by ilijaljubicic · Pull Request #46 · reqvire-org/reqvire

ilijaljubicic · 2026-01-25T20:26:22Z

What does this PR do?

Implements attachment scope constraints for refinement elements (specifications, constraints, behaviors):

Satisfied Refinement Constraint - Refinements must have at least one satisfy relation before they can be attached to other requirements
Hierarchical Independence Constraint - Attachments are only allowed from requirements outside the owner's derivation hierarchy

Changes include:

Added SATISFACTION_RELATIONS constant in relation.rs
Added helper functions in graph_registry.rs: get_defining_requirements(), refinement_has_satisfy_relations(), is_in_hierarchy()
Added validation in validate_attachments() for both constraints
Added enforcement in attach_element() (link command) for both constraints
Added enforcement in merge_elements() for both constraints
Updated reqvire's own model to comply with new constraints
Added e2e test suite test-attachment-constraints
Updated Claude plugin documentation
Updated www.reqvire.org documentation

Type of Change

Bug fix
New feature
Documentation
Refactoring/cleanup

Testing

Tests pass (cargo test)
I tested my changes

Requirements Changes

No requirements were changed
Requirements updated and /reqvire impact run in PR

Checklist

Code follows project style (cargo fmt, cargo clippy)
I have read the contributing guidelines

Requirements: - Add Attachment Scope Constraints requirement to ModelManagement.md - Add Hierarchical Independence and Satisfied Refinement constraints - Add Attachment Scope Validation requirement - Add test verification with comprehensive test cases Constraints enforce: - Refinements must have satisfy relations before being attachable - Attachments only allowed from requirements outside defining hierarchy Updates: - Add constraint attachments to functional requirements and CLI commands - Update ReservedSubsections.md design document with new validation rules - Add satisfy relations to refinement elements in test fixtures - Fix test-custom-element-types git config issue in nested repo New test: tests/test-attachment-constraints/ (spec for future implementation)

Two new validation constraints ensure proper attachment semantics: 1. Attachment Satisfied Refinement Constraint: - Refinements must have satisfy relations before being attachable - Ensures refinements have an established owner requirement 2. Attachment Hierarchical Independence Constraint: - Attachments only allowed from requirements outside the owner's hierarchy - Requirements in the same derivation chain access refinements through the hierarchy, not attachments Implementation: - Add SATISFACTION_RELATIONS constant in relation.rs - Add helper functions in graph_registry.rs for hierarchy checking - Add validation in validate_attachments(), attach_element(), merge_elements() - Update reqvire model to use satisfiedBy instead of redundant attachments - Update claude-plugins documentation with new constraints - Update test fixtures to comply with new constraints

- Nav background: #1c1c1c (dark gray) - Buttons/primary: #333333 (lighter gray) - Update Web Interface Style Specification with MONO color palette - Update test expected files for new theme colors

github-actions · 2026-01-25T20:26:33Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

ilijaljubicic · 2026-01-25T20:26:37Z

/reqvire impact

github-actions · 2026-01-25T20:27:45Z

Change Impact Report

New Elements

Attachment Scope Validation
- verifiedBy -> Attachment Scope Constraints Test (new)
  - satisfiedBy -> test.sh

Changed Elements

Element Manipulation Operations ⚠️
- 📎 Diff Output Format Specification
- satisfiedBy -> Dry-Run Mode Behavior
- satisfiedBy -> File Persistence Behavior
- derive -> Attachment Identifier Updates ⚠️
  - verifiedBy -> Attachment Identifier CRUD Verification
  - satisfiedBy -> crud.rs
  - satisfiedBy -> Attachment Identifier CRUD Update Behavior
- derive -> Create Element Operation ⚠️
  - 📎 Target Location Constraint
  - 📎 Element Ordering Behavior
  - 📎 Attachment Hierarchical Independence Constraint
  - 📎 Attachment Satisfied Refinement Constraint
  - verifiedBy -> Create Element Override Test
    - 📎 Create Element Override Behavior
  - verifiedBy -> Create Element Test
    - satisfiedBy -> test.sh
  - satisfiedBy -> cli.rs
  - satisfiedBy -> diff.rs
  - satisfiedBy -> graph_registry.rs
  - satisfiedBy -> parser.rs
  - satisfiedBy -> utils.rs
  - satisfiedBy -> Create Element Override Behavior
  - satisfiedBy -> Create Element Workflow Specification
  - satisfiedBy -> Relation Validation Specification
- derive -> Delete Element Operation
  - verifiedBy -> Delete Element Test
  - satisfiedBy -> Delete Element Workflow Specification
  - satisfiedBy -> Orphaned Children Error Message Specification
- derive -> Merge Element Operation ⚠️
  - 📎 Attachment Hierarchical Independence Constraint
  - 📎 Attachment Satisfied Refinement Constraint
  - verifiedBy -> Merge Elements Test
  - satisfiedBy -> Merge Content Transformation Behavior
  - satisfiedBy -> Merge Type Compatibility Constraint
  - satisfiedBy -> Merge Element Workflow Specification
- derive -> Move Element Operation
  - 📎 Target Location Constraint
  - 📎 Element Ordering Behavior
  - verifiedBy -> Move Element Test
    - satisfiedBy -> test.sh
  - satisfiedBy -> Move Element Workflow Specification
- derive -> Move File Operation
  - 📎 Target Location Constraint
  - verifiedBy -> Move File Squash Test
    - satisfiedBy -> test.sh
- derive -> Relation Consistency Maintenance
  - verifiedBy -> Relation Consistency Test
    - satisfiedBy -> test.sh
- derive -> Rename Element Operation
Refinement Element Structure Constraints
- 📎 requirements/Functional/Core/DesignDocuments/RelationTypes.md
- 📎 Supported Element Types Specification
- verifiedBy -> Refinement Element Type Parsing Test
- verifiedBy -> Refinement Relations Rejection Test
- satisfiedBy -> model.rs
- derive -> Attachment Scope Constraints (new)
  - 📎 Relation Semantics Specification
  - verifiedBy -> Attachment Scope Constraints Test (new)
    - satisfiedBy -> test.sh
  - satisfiedBy -> Attachment Hierarchical Independence Constraint (new)
  - satisfiedBy -> Attachment Satisfied Refinement Constraint (new)
Relation Management Operations ⚠️
- 📎 Attachment Hierarchical Independence Constraint ⚠️
- 📎 Attachment Satisfied Refinement Constraint ⚠️
- verifiedBy -> Link Command Verification
  - satisfiedBy -> test.sh
- satisfiedBy -> Relation Operations Specification
Reserved Subsections Support ⚠️
- 📎 requirements/Functional/Core/DesignDocuments/ReservedSubsections.md ⚠️
- verifiedBy -> Attachment Output Rendering Verification
  - satisfiedBy -> test.sh
- verifiedBy -> Attachments Subsection Parsing Verification
- verifiedBy -> Non-Reserved Subsections Content Test
- satisfiedBy -> Element Type Metadata Specification
- derive -> Verification Type Categories
  - 📎 Supported Element Types Specification
  - satisfiedBy -> Verification Type Selection Guidelines
- derive -> Attachment Commands ⚠️
  - 📎 File Persistence Behavior
  - 📎 Dry Run Mode Behavior
  - 📎 Diff Output Format Specification
  - 📎 Attachment Hierarchical Independence Constraint
  - 📎 Attachment Satisfied Refinement Constraint
  - verifiedBy -> Attach Command Verification
  - verifiedBy -> Detach Command Verification
  - satisfiedBy -> Attachment Input Auto-Detection Behavior
Attachment Target Validation ⚠️
- 📎 requirements/Functional/Core/DesignDocuments/ReservedSubsections.md ⚠️
- verifiedBy -> Attachments Subsection Parsing Verification
  - satisfiedBy -> test.sh
GraphRegistry as Primary Registry ⚠️
- verifiedBy -> Requirements Files Search and Detection Test
  - satisfiedBy -> test.sh
- satisfiedBy -> Requirements Processing Specification
Target Location Validation and Auto-Creation ⚠️
- verifiedBy -> Target Location Validation Test
  - satisfiedBy -> test.sh
- satisfiedBy -> graph_registry.rs
- satisfiedBy -> utils.rs
- satisfiedBy -> Target Location Constraint
Element Ordering Normalization ⚠️
- verifiedBy -> Element Ordering Verification
  - 📎 Element Ordering Behavior ⚠️
  - satisfiedBy -> test.sh
- satisfiedBy -> Element Ordering Behavior
Diagram Generation ⚠️
- verifiedBy -> Diagram Generation Test
- verifiedBy -> Diagram Relation Filtering Verification
- verifiedBy -> Visualize Model Relationships Verification
- satisfiedBy -> diagrams.rs
- satisfiedBy -> utils.rs
- satisfiedBy -> Diagram Relation Filtering Specification
- derive -> File Diagram Attachment Display ⚠️
  - verifiedBy -> File Diagram Attachment Test
- derive -> Interactive Mermaid Diagram Node Behavior ⚠️
- derive -> SysML-Compatible Relationship Rendering ⚠️
  - satisfiedBy -> SysML Rendering Specification
Interactive Mermaid Diagrams ⚠️
- satisfiedBy -> Diagram Relation Filtering Specification
- satisfiedBy -> Mermaid Diagram Generation Specification
- satisfiedBy -> Mermaid Diagram Style Specification
- satisfiedBy -> Mermaid Interactive Features Specification
Collect Content from Requirement Chain ⚠️
- satisfiedBy -> report_collect.rs
- satisfiedBy -> Collect Content Specification
- satisfiedBy -> Collect Output Format Specification
Containment View Report ⚠️
- 📎 requirements/Functional/Output/DesignDocuments/ContainmentView.md
- 📎 Containment Specification
- 📎 Mermaid Diagram Generation Specification
- 📎 Resources Report Format Specification
- verifiedBy -> Containment View Design Documents Test
  - satisfiedBy -> test.sh
- satisfiedBy -> containment.rs
Model Diagram Output Formats ⚠️
- 📎 Mermaid Diagram Generation Specification
- 📎 Diagram Relation Filtering Specification
- verifiedBy -> Model Command Verification
  - satisfiedBy -> test.sh
- derive -> Reverse Relation Traversal
  - 📎 Diagram Relation Filtering Specification
  - verifiedBy -> Reverse Model Traversal Test
    - 📎 Reverse Relation Traversal Behavior
  - satisfiedBy -> report_model.rs
  - satisfiedBy -> Reverse Relation Traversal Behavior
- derive -> Start Element Type Filtering
  - verifiedBy -> Start Type Filter Test
    - 📎 Start Element Type Filter Behavior
  - satisfiedBy -> Start Element Type Filter Behavior
Search Report Generator ⚠️
- 📎 requirements/Functional/Output/DesignDocuments/SearchFiltering.md
- 📎 Supported Element Types Specification
- 📎 Resources Report Format Specification
- verifiedBy -> Search Command Tests
  - satisfiedBy -> test.sh
- satisfiedBy -> filters.rs
- satisfiedBy -> search.rs
- derive -> Flexible Search Type Filtering
  - derive -> Comma-Separated Type Filter Parsing
    - verifiedBy -> Multi-Type Search Filter Test
      - satisfiedBy -> test.sh
Validation Report Generator ⚠️
- satisfiedBy -> model.rs
Verification Coverage Report ⚠️
- 📎 Verification Coverage Specification
- 📎 Verification Roll Up Specification
- 📎 Verification Type Selection Guidelines
- satisfiedBy -> report_coverage.rs
- satisfiedBy -> Verification Coverage Philosophy Behavior
- derive -> TraceFlow View Report Generation ⚠️
  - 📎 requirements/Functional/Output/DesignDocuments/TraceFlowView.md
  - 📎 Traceability Reporting Specification
  - 📎 Verification Roll Up Specification
  - 📎 Verification Trace Tree Construction
  - verifiedBy -> TraceFlow View Test
    - satisfiedBy -> test.sh
  - satisfiedBy -> export.rs
  - satisfiedBy -> Verification Trace Diagram Specification
CLI Add Element Command ⚠️
- 📎 Git Repository Scope Specification
- 📎 File Persistence Behavior
- 📎 Target Location Constraint
- 📎 Dry Run Mode Behavior
- 📎 Create Element Override Behavior
- 📎 Diff Output Format Specification
- 📎 Json Output Structure
- 📎 Create Element Workflow Specification
- 📎 Attachment Hierarchical Independence Constraint ⚠️
- 📎 Attachment Satisfied Refinement Constraint ⚠️
- verifiedBy -> Add Command Duplicate Detection Test
  - satisfiedBy -> test.sh
- verifiedBy -> Add Command Error Messages Test
  - satisfiedBy -> test.sh
- verifiedBy -> CLI Add Element Test
  - 📎 Element Ordering Behavior
CLI Change Impact Report Command ⚠️
- 📎 Json Output Structure
- 📎 Text Output Formatting
- 📎 Mermaid Diagram Style Specification
- verifiedBy -> Change Impact Analysis Verification
  - satisfiedBy -> test.sh
- verifiedBy -> Change Impact Detection Test
  - satisfiedBy -> test.sh
- verifiedBy -> CLI Git Commit Hash Flag Test
- satisfiedBy -> Change Propagation Behavior
CLI Containment Command ⚠️
- 📎 Json Output Structure
- 📎 Mermaid Diagram Style Specification
- 📎 requirements/Functional/Output/DesignDocuments/ContainmentView.md
- 📎 D3js Containment Tree Specification
- satisfiedBy -> cli.rs
- satisfiedBy -> containment.rs
- satisfiedBy -> diagrams.rs
- satisfiedBy -> Short Mode Behavior
CLI Merge Element Command ⚠️
- 📎 Merge Content Transformation Behavior
- 📎 Merge Type Compatibility Constraint
- 📎 Json Output Structure
- 📎 Merge Element Workflow Specification
- 📎 Attachment Hierarchical Independence Constraint ⚠️
- 📎 Attachment Satisfied Refinement Constraint ⚠️
- satisfiedBy -> cli.rs
CLI Resources Command ⚠️
- verifiedBy -> Resources Report Verification
  - satisfiedBy -> test.sh
Validate Command ⚠️
- 📎 Two Pass Validation Behavior
- 📎 Validation Error Reporting Behavior
- 📎 Json Output Structure
- 📎 Error Message Format Specification
- 📎 Attachment Hierarchical Independence Constraint ⚠️
- 📎 Attachment Satisfied Refinement Constraint ⚠️
- verifiedBy -> Invalid Relations Test
  - satisfiedBy -> test.sh
HTML Export ⚠️
- verifiedBy -> CLI Help Structure Verification
  - satisfiedBy -> test.sh
- verifiedBy -> HTML Export Verification
  - satisfiedBy -> test.sh
- satisfiedBy -> layouts.rs
- satisfiedBy -> mod.rs
- satisfiedBy -> html_export.rs
- satisfiedBy -> index_generator.rs
- satisfiedBy -> Web Interface Navigation Behavior
- satisfiedBy -> D3.js Containment Tree Specification
- satisfiedBy -> HTML Branding Specification
- satisfiedBy -> HTML Export Pipeline Specification
- satisfiedBy -> HTML Navigation Bar Specification
- satisfiedBy -> Web Interface Style Specification ⚠️
- derive -> Attachment Export
  - verifiedBy -> Attachment Export Verification
- derive -> Containment View Attachment Links ⚠️
  - verifiedBy -> Containment Attachment Links Verification
- derive -> Diagram Attachment Display
  - 📎 Mermaid Diagram Style Specification
  - verifiedBy -> Diagram Attachment Display Verification
- derive -> Model-Centric View Generation ⚠️
  - 📎 Mermaid Diagram Style Specification
  - derive -> Model View Element Navigation
    - verifiedBy -> Model View Element Navigation Test
- derive -> Web Interface Color Scheme ⚠️
  - satisfiedBy -> styles.rs
  - satisfiedBy -> Color Scheme Specification

Invalidated Verifications

Test User added 5 commits January 25, 2026 19:30

Update HTML theme to MONO grayscale color scheme

9c3e2e5

- Nav background: #1c1c1c (dark gray) - Buttons/primary: #333333 (lighter gray) - Update Web Interface Style Specification with MONO color palette - Update test expected files for new theme colors

Update documentation and dependencies for attachment scope constraints

c3ccc3d

Update assets, remove accidental docs folder, update submodule

6fea46d

- Update favicon and logo assets - Remove accidentally committed docs/ folder - Update www.reqvire.org submodule (copyright 2026)

ilijaljubicic merged commit ddda18a into main Jan 25, 2026
2 of 3 checks passed

ilijaljubicic deleted the improved-system-model-metarch branch January 25, 2026 20:28

github-actions bot locked and limited conversation to collaborators Jan 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved system model metarch#46

Improved system model metarch#46
ilijaljubicic merged 5 commits intomainfrom
improved-system-model-metarch

ilijaljubicic commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

ilijaljubicic commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026 •

edited by ilijaljubicic

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ilijaljubicic commented Jan 25, 2026

What does this PR do?

Type of Change

Testing

Requirements Changes

Checklist

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

ilijaljubicic commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026 • edited by ilijaljubicic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Impact Report

New Elements

Changed Elements

Invalidated Verifications

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Jan 25, 2026 •

edited by ilijaljubicic

Loading