Drop fedora-messaging

The service was never deployed for Fedora, let's not pull in the extra
dependency for that.

Author: lubomir

Dockerfile

@@ -22,7 +22,6 @@ RUN dnf -y --setopt=install_weak_deps=False update \
         mod_ldap \
         mod_ssl \
         python3-defusedxml \
-        python3-fedora \
         python3-flask \
         python3-flask-login \
         python3-flask-migrate \

conf/config.py

@@ -55,7 +55,7 @@ class BaseConfiguration(object):
 
     # Select backend where message will be sent to. Currently, umb is supported
     # which means the Unified Message Bus.
-    MESSAGING_BACKEND = ""  # fedora-messaging or umb
+    MESSAGING_BACKEND = ""  # rhmsg
 
     # List of broker URLs. Each of them is a string consisting of domain and
     # optiona port.

cts/config.py

@@ -144,7 +144,7 @@ class Config(object):
         "messaging_backend": {
             "type": str,
             "default": "",
-            "desc": "Messaging backend, rhmsg or fedora-messaging.",
+            "desc": "Messaging backend, rhmsg.",
         },
         "messaging_broker_urls": {
             "type": list,
@@ -169,7 +169,7 @@ class Config(object):
         "messaging_topic_prefix": {
             "type": str,
             "default": "cts.",
-            "desc": "Prefix for AMQP or fedora-messaging messages.",
+            "desc": "Prefix for AMQP messages.",
         },
         "oidc_base_namespace": {
             "type": str,

cts/messaging.py

@@ -119,23 +119,9 @@ def _send():
     _retry_with_backoff(_send)
 
 
-def _fedora_messaging_send_msg(msgs):
-    """Send message to fedora-messaging."""
-    from fedora_messaging import api, config
-
-    config.conf.setup_logging()
-
-    for msg in msgs:
-        event = msg.get("event", "event")
-        topic = "%s%s" % (conf.messaging_topic_prefix, event)
-        api.publish(api.Message(topic=topic, body=msg))
-
-
 def _get_messaging_backend():
     if conf.messaging_backend == "rhmsg":
         return _umb_send_msg
-    elif conf.messaging_backend == "fedora-messaging":
-        return _fedora_messaging_send_msg
     elif conf.messaging_backend:
         raise ValueError("Unknown messaging backend {0}".format(conf.messaging_backend))
     else:

docs/api.rst

@@ -21,7 +21,7 @@ For production env running via httpd for example, `openapispec.json` should be s
 Messaging API
 =============
 
-CTS also sends AMQP or fedora-messaging messages when Compose changes.
+CTS also sends AMQP messages when Compose changes.
 
 Topic: cts.compose-created
 --------------------------

requirements.txt

@@ -1,4 +1,3 @@
-python-fedora
 sqlalchemy<2.0  # For Flask 2.2.3
 Flask==2.2.3  # Pin version for Flask-Login
 Flask-Migrate

tests/test_events.py

@@ -36,11 +36,6 @@
 except ImportError:
     rhmsg = None
 
-try:
-    import fedora_messaging
-except ImportError:
-    fedora_messaging = None
-
 
 @unittest.skipUnless(rhmsg, "rhmsg is required to run this test case.")
 class TestRHMsgSendMessageWhenComposeIsCreated(ModelsBaseTest):
@@ -86,43 +81,6 @@ def test_send_message(self, Message, AMQProducer):
             producer_send.assert_called_once_with(Message.return_value)
 
 
-@unittest.skipUnless(
-    fedora_messaging, "fedora_messaging is required to run this test case."
-)
-class TestFedoraMessagingSendMessageWhenComposeIsCreated(ModelsBaseTest):
-    """Test send message when compose is created"""
-
-    disable_event_handlers = False
-
-    def setUp(self):
-        super(TestFedoraMessagingSendMessageWhenComposeIsCreated, self).setUp()
-
-        # Real lock is not required for running tests
-        self.mock_lock = patch("threading.Lock")
-        self.mock_lock.start()
-
-    def tearDown(self):
-        super(TestFedoraMessagingSendMessageWhenComposeIsCreated, self).tearDown()
-        self.mock_lock.stop()
-
-    def setup_composes(self):
-        User.create_user(username="odcs")
-        self.compose = Compose.create(db.session, "odcs", self.ci)[0]
-
-    @patch.object(conf, "messaging_backend", new="fedora-messaging")
-    @patch("fedora_messaging.api.Message")
-    @patch("fedora_messaging.api.publish")
-    def test_send_message(self, publish, Message):
-        compose = Compose.create(db.session, "odcs", self.ci)[0]
-
-        Message.assert_called_once_with(
-            topic="cts.compose-created",
-            body={"event": "compose-created", "compose": compose.json()},
-        )
-
-        publish.assert_called_once_with(Message.return_value)
-
-
 @patch("cts.messaging.publish")
 class TestMessaging(ModelsBaseTest):
     """Test send message when compose is created"""