Skip to content

Commit 6b9ea99

Browse files
committed
update XMLparser
1 parent 892df09 commit 6b9ea99

9 files changed

Lines changed: 68 additions & 285 deletions

File tree

lib/relaton_ogc/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module RelatonOgc
2-
VERSION = "1.18.0".freeze
2+
VERSION = "1.18.1".freeze
33
end

lib/relaton_ogc/xml_parser.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ def bib_item(item_hash)
1212
OgcBibliographicItem.new(**item_hash)
1313
end
1414

15+
def create_doctype(type)
16+
DocumentType.new type: type.text, abbreviation: type[:abbreviation]
17+
end
18+
1519
# Override RelatonIsoBib::XMLParser.item_data method.
1620
# @param item [Nokogiri::XML::Element]
1721
# @returtn [Hash]

spec/relaton_ogc/hash_converter_spec.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,12 @@
55
item = RelatonOgc::OgcBibliographicItem.from_hash hash
66
expect(item.to_hash).to eq hash
77
end
8+
9+
it "create doctype" do
10+
hash = { type: "standard", abbreviation: "ST" }
11+
doctype = RelatonOgc::HashConverter.send(:create_doctype, **hash)
12+
expect(doctype).to be_instance_of RelatonOgc::DocumentType
13+
expect(doctype.type).to eq "standard"
14+
expect(doctype.abbreviation).to eq "ST"
15+
end
816
end

spec/relaton_ogc/xml_parser_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,14 @@
1717
.to_stderr
1818
expect(item).to be_nil
1919
end
20+
21+
it "creates doctype" do
22+
xml = Nokogiri::XML(<<~XML).at("/doctype")
23+
<doctype abbreviation="ST">standard</doctype>
24+
XML
25+
doctype = RelatonOgc::XMLParser.send :create_doctype, xml
26+
expect(doctype).to be_instance_of RelatonOgc::DocumentType
27+
expect(doctype.type).to eq "standard"
28+
expect(doctype.abbreviation).to eq "ST"
29+
end
2030
end

spec/vcr_cassettes/ogc_09_048r5.yml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/ogc_12_128r14.yml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/ogc_15_043r3.yml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/ogc_16_079.yml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)