require passed featureList in order to override locally

Author: laander

packages/browser-sdk/src/feature/features.ts

@@ -274,6 +274,10 @@ export class FeaturesClient {
     return this.features;
   }
 
+  getFetchedFeatures(): FetchedFeatures {
+    return this.fetchedFeatures;
+  }
+
   public async fetchFeatures(): Promise<FetchedFeatures | undefined> {
     const params = this.fetchParams();
     try {

packages/browser-sdk/test/features.test.ts

@@ -1,6 +1,7 @@
 import { afterAll, beforeEach, describe, expect, test, vi } from "vitest";
 
 import { version } from "../package.json";
+import { FeatureDefinitions } from "../src/client";
 import {
   FEATURES_EXPIRE_MS,
   FeaturesClient,
@@ -36,6 +37,7 @@ function featuresClientFactory() {
     newFeaturesClient: function newFeaturesClient(
       options?: FeaturesOptions,
       context?: any,
+      featureList: FeatureDefinitions = [],
     ) {
       return new FeaturesClient(
         httpClient,
@@ -45,7 +47,7 @@ function featuresClientFactory() {
           other: { eventId: "big-conference1" },
           ...context,
         },
-        [],
+        featureList,
         testLogger,
         {
           cache,
@@ -302,16 +304,20 @@ describe("FeaturesClient unit tests", () => {
   test("handled overrides for features not returned by API", async () => {
     // change the response so we can validate that we'll serve the stale cache
     const { newFeaturesClient } = featuresClientFactory();
+
     // localStorage.clear();
-    const client = newFeaturesClient();
+    const client = newFeaturesClient(undefined, undefined, ["featureB"]);
     await client.initialize();
 
     let updated = false;
     client.onUpdated(() => {
       updated = true;
     });
 
-    expect(client.getFeatures().featureB).toBeUndefined();
+    expect(client.getFeatures().featureB.isEnabled).toBe(false);
+    expect(client.getFeatures().featureB.isEnabledOverride).toBe(null);
+
+    expect(client.getFetchedFeatures()?.featureB).toBeUndefined();
 
     client.setFeatureOverride("featureB", true);