Merge branch 'main' into dependabot/npm_and_yarn/next-14.2.15

Author: roncohen

.github/workflows/package-ci.yml

@@ -10,7 +10,7 @@ on: [push]
 jobs:
   build-and-test:
     name: Build & Test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout source code
         uses: actions/checkout@v3

packages/browser-sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/browser-sdk",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "packageManager": "[email protected]",
   "license": "MIT",
   "repository": {
@@ -27,8 +27,14 @@
     "dist"
   ],
   "main": "./dist/bucket-browser-sdk.umd.js",
-  "module": "./dist/bucket-browser-sdk.mjs",
   "types": "./dist/types/src/index.d.ts",
+  "exports": {
+    ".": {
+      "import": "./dist/bucket-browser-sdk.mjs",
+      "require": "./dist/bucket-browser-sdk.umd.js",
+      "types": "./dist/types/src/index.d.ts"
+    }
+  },
   "dependencies": {
     "@floating-ui/dom": "^1.6.8",
     "canonical-json": "^0.0.4",

packages/browser-sdk/vite.config.js packages/browser-sdk/vite.config.mjspackages/browser-sdk/vite.config.js renamed to packages/browser-sdk/vite.config.mjs

@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/openfeature-browser-provider",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "packageManager": "[email protected]",
   "license": "MIT",
   "repository": {
@@ -26,8 +26,14 @@
     "dist"
   ],
   "main": "./dist/bucket-openfeature-browser-provider.umd.js",
-  "module": "./dist/bucket-openfeature-browser-provider.mjs",
-  "types": "./dist/types/src/index.d.ts",
+  "types": "./dist/index.d.ts",
+  "exports": {
+    ".": {
+      "import": "./dist/bucket-openfeature-browser-provider.mjs",
+      "require": "./dist/bucket-openfeature-browser-provider.umd.js",
+      "types": "./dist/index.d.ts"
+    }
+  },
   "dependencies": {
     "@bucketco/browser-sdk": "2.4.0"
   },

packages/openfeature-browser-provider/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/openfeature-node-provider",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "access": "public"
   },
   "main": "./dist/src/index.js",
-  "types": "./dist/types/src/index.d.ts",
+  "types": "./dist/types/index.d.ts",
   "devDependencies": {
     "@babel/core": "~7.24.7",
     "@bucketco/eslint-config": "~0.0.2",

packages/openfeature-node-provider/package.json

@@ -106,7 +106,15 @@ function StartHuddleButton() {
     <>
       <button onClick={track}>Start huddle!</button>
       <button
-        onClick={() => requestFeedback({ title: "How do you like Huddles?" })}
+        onClick={(e) =>
+          requestFeedback({
+            title: "How do you like Huddles?",
+            position: {
+              type: "POPOVER",
+              anchor: e.currentTarget as HTMLElement,
+            },
+          })
+        }
       >
         Give feedback!
       </button>
@@ -139,15 +147,28 @@ function StartHuddle() {
 `useRequestFeedback()` returns a function that lets you open up a dialog to ask for feedback on a specific feature.
 See [Automated Feedback Surveys](https://docs.bucket.co/product-handbook/live-satisfaction) for how to do this automatically, without code.
 
-```ts
+When using the `useRequestFeedback` you must pass the feature key to `requestFeedback`.
+The example below shows how to use `position` to ensure the popover appears next to the "Give feedback!" button.
+
+```tsx
 import { useTrackEvent } from "@bucketco/react-sdk";
 
 const requestFeedback = useRequestFeedback();
 
-requestFeedback({
-  featureId: "bucket-feature-id",
-  title: "How satisfied are you with file uploads?",
-});
+<button
+  onClick={(e) =>
+    requestFeedback({
+      featureKey: "huddle-feature-key",
+      title: "How satisfied are you with file uploads?",
+      position: {
+        type: "POPOVER",
+        anchor: e.currentTarget as HTMLElement,
+      },
+    })
+  }
+>
+  Give feedback!
+</button>;
 ```
 
 See https://github.com/bucketco/bucket-javascript-sdk/blob/main/packages/browser-sdk/FEEDBACK.md#manual-feedback-collection for more information on `requestFeedback`

packages/react-sdk/README.md

@@ -157,11 +157,16 @@ function Feedback() {
     <div>
       <h2>Feedback</h2>
       <button
-        onClick={() => {
+        onClick={(e) =>
           requestFeedback({
-            featureId: "fe123",
-          });
-        }}
+            title: "How do you like Huddles?",
+            featureKey: "huddle",
+            position: {
+              type: "POPOVER",
+              anchor: e.currentTarget as HTMLElement,
+            },
+          })
+        }
       >
         Request feedback
       </button>

packages/react-sdk/dev/plain/app.tsx

@@ -1,6 +1,6 @@
 {
   "name": "@bucketco/react-sdk",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -24,11 +24,17 @@
   "files": [
     "dist"
   ],
-  "main": "./dist/bucket-react-sdk.js",
-  "module": "./dist/bucket-react-sdk.mjs",
-  "types": "./dist/types/src/index.d.ts",
+  "main": "./dist/bucket-react-sdk.umd.js",
+  "types": "./dist/index.d.ts",
+  "exports": {
+    ".": {
+      "import": "./dist/bucket-react-sdk.mjs",
+      "require": "./dist/bucket-react-sdk.umd.js",
+      "types": "./dist/index.d.ts"
+    }
+  },
   "dependencies": {
-    "@bucketco/browser-sdk": "2.4.0",
+    "@bucketco/browser-sdk": "2.4.1",
     "canonical-json": "^0.0.4"
   },
   "peerDependencies": {

packages/react-sdk/package.json

@@ -14,7 +14,6 @@ import {
 } from "vitest";
 
 import { BucketClient } from "@bucketco/browser-sdk";
-import { HttpClient } from "@bucketco/browser-sdk/src/httpClient";
 
 import { version } from "../package.json";
 import {
@@ -137,9 +136,6 @@ afterAll(() => server.close());
 beforeAll(() => {
   vi.spyOn(BucketClient.prototype, "initialize");
   vi.spyOn(BucketClient.prototype, "stop");
-
-  vi.spyOn(HttpClient.prototype, "get");
-  vi.spyOn(HttpClient.prototype, "post");
 });
 
 beforeEach(() => {

packages/react-sdk/test/usage.test.tsx

@@ -21,10 +21,15 @@ export default defineConfig({
       entry: resolve(__dirname, "src/index.tsx"),
       name: "BucketReactSDK",
       fileName: "bucket-react-sdk",
-      formats: ["es"],
+      formats: ["es", "umd"],
     },
     rollupOptions: {
       external: ["react", "react-dom"],
+      output: {
+        globals: {
+          react: "React",
+        },
+      },
     },
   },
   server: {