Skip to content

Commit c7c52a7

Browse files
aamijaraamijar
committed
const params& config
1 parent 074fd96 commit c7c52a7

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

‎cpp/include/cuvs/preprocessing/pca.hpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ struct params {
9797
* @param[in] flip_signs_based_on_U whether to determine signs by U (true) or V.T (false)
9898
*/
9999
void fit(raft::resources const& handle,
100-
params config,
100+
const params& config,
101101
raft::device_matrix_view<float, int64_t, raft::col_major> input,
102102
raft::device_matrix_view<float, int64_t, raft::col_major> components,
103103
raft::device_vector_view<float, int64_t> explained_var,
@@ -108,7 +108,7 @@ void fit(raft::resources const& handle,
108108
bool flip_signs_based_on_U = false);
109109

110110
void fit(raft::resources const& handle,
111-
params config,
111+
const params& config,
112112
raft::device_matrix_view<double, int64_t, raft::col_major> input,
113113
raft::device_matrix_view<double, int64_t, raft::col_major> components,
114114
raft::device_vector_view<double, int64_t> explained_var,
@@ -137,7 +137,7 @@ void fit(raft::resources const& handle,
137137
* @param[in] flip_signs_based_on_U whether to determine signs by U (true) or V.T (false)
138138
*/
139139
void fit_transform(raft::resources const& handle,
140-
params config,
140+
const params& config,
141141
raft::device_matrix_view<float, int64_t, raft::col_major> input,
142142
raft::device_matrix_view<float, int64_t, raft::col_major> trans_input,
143143
raft::device_matrix_view<float, int64_t, raft::col_major> components,
@@ -149,7 +149,7 @@ void fit_transform(raft::resources const& handle,
149149
bool flip_signs_based_on_U = false);
150150

151151
void fit_transform(raft::resources const& handle,
152-
params config,
152+
const params& config,
153153
raft::device_matrix_view<double, int64_t, raft::col_major> input,
154154
raft::device_matrix_view<double, int64_t, raft::col_major> trans_input,
155155
raft::device_matrix_view<double, int64_t, raft::col_major> components,
@@ -175,15 +175,15 @@ void fit_transform(raft::resources const& handle,
175175
* @param[out] trans_input transformed data [n_rows x n_components] (col-major)
176176
*/
177177
void transform(raft::resources const& handle,
178-
params config,
178+
const params& config,
179179
raft::device_matrix_view<float, int64_t, raft::col_major> input,
180180
raft::device_matrix_view<float, int64_t, raft::col_major> components,
181181
raft::device_vector_view<float, int64_t> singular_vals,
182182
raft::device_vector_view<float, int64_t> mu,
183183
raft::device_matrix_view<float, int64_t, raft::col_major> trans_input);
184184

185185
void transform(raft::resources const& handle,
186-
params config,
186+
const params& config,
187187
raft::device_matrix_view<double, int64_t, raft::col_major> input,
188188
raft::device_matrix_view<double, int64_t, raft::col_major> components,
189189
raft::device_vector_view<double, int64_t> singular_vals,
@@ -204,15 +204,15 @@ void transform(raft::resources const& handle,
204204
* @param[out] output reconstructed data [n_rows x n_cols] (col-major)
205205
*/
206206
void inverse_transform(raft::resources const& handle,
207-
params config,
207+
const params& config,
208208
raft::device_matrix_view<float, int64_t, raft::col_major> trans_input,
209209
raft::device_matrix_view<float, int64_t, raft::col_major> components,
210210
raft::device_vector_view<float, int64_t> singular_vals,
211211
raft::device_vector_view<float, int64_t> mu,
212212
raft::device_matrix_view<float, int64_t, raft::col_major> output);
213213

214214
void inverse_transform(raft::resources const& handle,
215-
params config,
215+
const params& config,
216216
raft::device_matrix_view<double, int64_t, raft::col_major> trans_input,
217217
raft::device_matrix_view<double, int64_t, raft::col_major> components,
218218
raft::device_vector_view<double, int64_t> singular_vals,

‎cpp/src/preprocessing/pca/detail/pca.cuh‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace cuvs::preprocessing::pca::detail {
1616
/**
1717
* @brief Convert cuvs::preprocessing::pca::params to raft::linalg::paramsPCA.
1818
*/
19-
inline auto to_raft_params(params config, std::size_t n_rows, std::size_t n_cols)
19+
inline auto to_raft_params(const params& config, std::size_t n_rows, std::size_t n_cols)
2020
-> raft::linalg::paramsPCA
2121
{
2222
raft::linalg::paramsPCA prms;
@@ -33,7 +33,7 @@ inline auto to_raft_params(params config, std::size_t n_rows, std::size_t n_cols
3333

3434
template <typename DataT, typename IndexT>
3535
void fit(raft::resources const& handle,
36-
params config,
36+
const params& config,
3737
raft::device_matrix_view<DataT, IndexT, raft::col_major> input,
3838
raft::device_matrix_view<DataT, IndexT, raft::col_major> components,
3939
raft::device_vector_view<DataT, IndexT> explained_var,
@@ -58,7 +58,7 @@ void fit(raft::resources const& handle,
5858

5959
template <typename DataT, typename IndexT>
6060
void fit_transform(raft::resources const& handle,
61-
params config,
61+
const params& config,
6262
raft::device_matrix_view<DataT, IndexT, raft::col_major> input,
6363
raft::device_matrix_view<DataT, IndexT, raft::col_major> trans_input,
6464
raft::device_matrix_view<DataT, IndexT, raft::col_major> components,
@@ -85,7 +85,7 @@ void fit_transform(raft::resources const& handle,
8585

8686
template <typename DataT, typename IndexT>
8787
void transform(raft::resources const& handle,
88-
params config,
88+
const params& config,
8989
raft::device_matrix_view<DataT, IndexT, raft::col_major> input,
9090
raft::device_matrix_view<DataT, IndexT, raft::col_major> components,
9191
raft::device_vector_view<DataT, IndexT> singular_vals,
@@ -98,7 +98,7 @@ void transform(raft::resources const& handle,
9898

9999
template <typename DataT, typename IndexT>
100100
void inverse_transform(raft::resources const& handle,
101-
params config,
101+
const params& config,
102102
raft::device_matrix_view<DataT, IndexT, raft::col_major> trans_input,
103103
raft::device_matrix_view<DataT, IndexT, raft::col_major> components,
104104
raft::device_vector_view<DataT, IndexT> singular_vals,

‎cpp/src/preprocessing/pca/pca.cu‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace cuvs::preprocessing::pca {
1111

1212
#define CUVS_INST_PCA_FIT(DataT, IndexT) \
1313
void fit(raft::resources const& handle, \
14-
params config, \
14+
const params& config, \
1515
raft::device_matrix_view<DataT, IndexT, raft::col_major> input, \
1616
raft::device_matrix_view<DataT, IndexT, raft::col_major> components, \
1717
raft::device_vector_view<DataT, IndexT> explained_var, \
@@ -39,7 +39,7 @@ CUVS_INST_PCA_FIT(double, int64_t);
3939

4040
#define CUVS_INST_PCA_FIT_TRANSFORM(DataT, IndexT) \
4141
void fit_transform(raft::resources const& handle, \
42-
params config, \
42+
const params& config, \
4343
raft::device_matrix_view<DataT, IndexT, raft::col_major> input, \
4444
raft::device_matrix_view<DataT, IndexT, raft::col_major> trans_input, \
4545
raft::device_matrix_view<DataT, IndexT, raft::col_major> components, \
@@ -69,7 +69,7 @@ CUVS_INST_PCA_FIT_TRANSFORM(double, int64_t);
6969

7070
#define CUVS_INST_PCA_TRANSFORM(DataT, IndexT) \
7171
void transform(raft::resources const& handle, \
72-
params config, \
72+
const params& config, \
7373
raft::device_matrix_view<DataT, IndexT, raft::col_major> input, \
7474
raft::device_matrix_view<DataT, IndexT, raft::col_major> components, \
7575
raft::device_vector_view<DataT, IndexT> singular_vals, \
@@ -85,7 +85,7 @@ CUVS_INST_PCA_TRANSFORM(double, int64_t);
8585

8686
#define CUVS_INST_PCA_INVERSE_TRANSFORM(DataT, IndexT) \
8787
void inverse_transform(raft::resources const& handle, \
88-
params config, \
88+
const params& config, \
8989
raft::device_matrix_view<DataT, IndexT, raft::col_major> trans_input, \
9090
raft::device_matrix_view<DataT, IndexT, raft::col_major> components, \
9191
raft::device_vector_view<DataT, IndexT> singular_vals, \

0 commit comments

Comments
 (0)