update

Author: rouzwelt

src/gas.ts

@@ -1,8 +1,8 @@
 import { ChainId } from "sushi";
 import { BigNumber } from "ethers";
 import { getQuoteConfig } from "./utils";
+import { publicActionsL2 } from "viem/op-stack";
 import { encodeFunctionData, multicall3Abi, toHex } from "viem";
-import { publicActionsL2, walletActionsL2 } from "viem/op-stack";
 import { BotConfig, BundledOrders, OperationState, RawTx, ViemClient } from "./types";
 import { ArbitrumNodeInterfaceAbi, ArbitrumNodeInterfaceAddress, OrderbookQuoteAbi } from "./abis";
 
@@ -32,9 +32,7 @@ export async function estimateGasCost(
     };
     if (config.isSpecialL2) {
         try {
-            const l1Signer_ = l1Signer
-                ? l1Signer
-                : signer.extend(walletActionsL2()).extend(publicActionsL2());
+            const l1Signer_ = l1Signer ? l1Signer : signer.extend(publicActionsL2());
             if (typeof l1GasPrice !== "bigint") {
                 l1GasPrice = (await l1Signer_.getL1BaseFee()) as bigint;
             }

src/modes/routeProcessor.ts

@@ -498,7 +498,7 @@ export async function findOppWithRetries({
             // ie its maxInput is the greatest
             const prom = allPromises[i];
             if (prom.status === "fulfilled") {
-                if (!choice || choice.maximumInput!.lt(prom.value.value!.maximumInput!)) {
+                if (!choice || choice.estimatedProfit.lt(prom.value.value!.estimatedProfit)) {
                     // record the attributes of the choosing one
                     for (const attrKey in prom.value.spanAttributes) {
                         spanAttributes[attrKey] = prom.value.spanAttributes[attrKey];

test/gas.test.ts

@@ -1,8 +1,8 @@
 import { assert } from "chai";
+import { ChainId } from "sushi";
 import { orderPairObject1 } from "./data";
 import { OperationState, ViemClient } from "../src/types";
 import { estimateGasCost, getGasPrice, getL1Fee, getQuoteGas, getTxFee } from "../src/gas";
-import { ChainId } from "sushi";
 
 describe("Test gas", async function () {
     it("should estimate gas correctly for L1 and L2 chains", async function () {
@@ -80,7 +80,9 @@ describe("Test gas", async function () {
 
     it("should get tx fee", async function () {
         // mock config and receipt
-        const config = {} as any;
+        const config = {
+            chain: { id: 137 },
+        } as any;
         const receipt = {
             effectiveGasPrice: 10n,
             gasUsed: 5n,
@@ -102,6 +104,7 @@ describe("Test gas", async function () {
         const l1GasPrice = 2n;
         // mock config and viem client
         const config = {
+            chain: { id: 137 },
             isSpecialL2: false,
             gasPriceMultiplier: 100n,
             viemClient: { getGasPrice: async () => gasPrice },