Missing create_schema calls in schema.rb

[ryanb]

Steps to reproduce

Rails schema dump doesn't include create_schema calls in upcoming release due to #276.

Expected behavior

It would be nice if this were configurable. We have a few schemas that exist outside tenants that need to be included in schema.rb dump.

The only work-around appears to be to monkey-patch this monkey-patch to reverse the monkey-patch. 😉

Actual behavior

There's no way to configure it.

Let me know if you would like a PR to add a config option for this.

Thanks for your work on this gem! Looking forward to the next release.

[mnovelo]

I think that's reasonable. Happy to look over a PR, but wait until after the next release to create it since I'm refactoring a lot of the specs right now. I should have the next release done soon

[ryanb]

Thanks. If others need this same thing in the meantime, putting this in an initializer works to bring back the create_schema lines.

class ActiveRecord::ConnectionAdapters::PostgreSQL::SchemaDumper
  def schemas(stream)
    _original_schemas(stream)
  end
end

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mnovelo]

I plan to include this in the next version of the apartment gem

[mnovelo]

This was not included in 3.2.0, but my hope is to include this in the next major version which I'm actively working on right now

[mnovelo]

also, I'd love your input in #312

[ryanb]

Thanks @mnovelo, I appreciate your work on this!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.