Multiple elvation datasets

[jblanchg]

Hi there,

I believe it would be valuable to support multiple elevation rasters. This would not only allow retrieving more than one elevation value at a specific coordinate, but also enable their use with the HeightProfile tool.

For example, one raster could represent the terrain elevation, while another includes building heights making it possible to visualize both elevation levels simultaneously.

What do you think?

[manisandro]

Sure, happy to accept a PR!

[rsrg-zwiama]

Hi @jblanchg @manisandro ,

I checked out your new elevation service and the integration into qwc2. Since we are using before and after DTM's, we are very happy about the new service! What do you think about changing the qwc2, so we can render multiple datasets in the profile like this:

What do you think?

[manisandro]

No objections on my part!

[rsrg-zwiama]

I opened a PR for this.

While working and testing this feature, I found an error. When removing a vertex/point from a measure line, the app fails. This is already the case in the master version. So far a could not figure out, where the error comes from. Is this only a matter in my dev-env?

[manisandro]

I cannot reproduce the crash, can you show a stack trace?

[rsrg-zwiama]

When building qwc2 with yarn prod and using it in the docker compose project, I don't get an error. But I get this runtime error, when I test it with using yarn start (dev mode):

Uncaught Error: A state mutation was detected between dispatches, in the path 'map.click.features.0.properties.features.0.pendingRemovals_.change'.  This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state)
    node_modules Immutable
    measureTime Redux
    node_modules Immutable
    Redux 2
    MeasurementSupport MeasurementSupport.jsx:156
    MeasurementSupport MeasurementSupport.jsx:83
    dispatchEvent Target.js:114
    changed Observable.js:70
    handleGeometryChange_ Feature.js:229
    dispatchEvent Target.js:114
    changed Observable.js:70
    setCoordinates LineString.js:314
    setGeometryCoordinates_ Modify.js:1677
    removeVertex_ Modify.js:1579
    removePoint Modify.js:1478
    handleEvent Modify.js:868
    handleMapBrowserEvent Map.js:1168
    dispatchEvent Target.js:114
    clickTimeoutId_ MapBrowserEventHandler.js:156
    setTimeout handler*emulateClick_ MapBrowserEventHandler.js:149
    handlePointerUp_ MapBrowserEventHandler.js:225
    listen events.js:65
    handlePointerDown_ MapBrowserEventHandler.js:279
    listen events.js:65
    MapBrowserEventHandler MapBrowserEventHandler.js:89
    handleTargetChanged_ Map.js:1309
    dispatchEvent Target.js:114
    notify Object.js:184
    set Object.js:223
    setTarget Map.js:1685
    componentDidMount OlMap.jsx:141
    React 11
    workLoop scheduler.development.js:266
    flushWork scheduler.development.js:239
    performWorkUntilDeadline scheduler.development.js:533
    js scheduler.development.js:571
    js scheduler.development.js:633
    Webpack 19

[manisandro]

Should be fixed by [1].

[1] qgis/qwc2@58b9273