Skip to content

Commit ca4fabb

Browse files
committed
fix: always padd title - to match change in sense-client
1 parent f7bc948 commit ca4fabb

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

apis/nucleus/src/utils/cell-padding.js

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,12 @@ const NO_PADDING_IN_CARDS = [
1414
'sn-tabbed-container',
1515
];
1616

17-
const getPaddTitle = (visualization) => NO_BORDER_IN_CARDS.indexOf(visualization) === -1;
18-
19-
const getTitlePadding = (visualization) => {
20-
const paddTitle = getPaddTitle(visualization);
21-
if (paddTitle) {
22-
return '10px 10px 0';
23-
}
24-
return '10px 0 0';
25-
};
26-
const getSubtitlePadding = (visualization, showTitle) => {
27-
const paddTitle = getPaddTitle(visualization);
17+
const getTitlePadding = () => '10px 10px 0';
18+
const getSubtitlePadding = (showTitle) => {
2819
if (showTitle) {
29-
if (paddTitle) {
30-
return '0 10px';
31-
}
32-
return '0';
20+
return '0 10px';
3321
}
34-
return getTitlePadding(visualization);
22+
return getTitlePadding();
3523
};
3624

3725
const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) => {
@@ -46,11 +34,11 @@ const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) =
4634

4735
if (showTitle) {
4836
// eslint-disable-next-line no-param-reassign
49-
titleStyles.main.padding = getTitlePadding(visualization);
37+
titleStyles.main.padding = getTitlePadding();
5038
}
5139
if (showSubtitle) {
5240
// eslint-disable-next-line no-param-reassign
53-
titleStyles.subTitle.padding = getSubtitlePadding(visualization, showTitle);
41+
titleStyles.subTitle.padding = getSubtitlePadding(showTitle);
5442
}
5543
if (showFootnote) {
5644
if (NO_BORDER_IN_CARDS.indexOf(visualization) === -1) {

0 commit comments

Comments
 (0)