only start worker pool when there's jobs to do (#603)

* only start worker pool when there's jobs to do

Author: DnlLrssn

config/getappstructure.go

@@ -71,27 +71,30 @@ func (settings *GetAppStructureSettings) Execute(sessionState *session.State, ac
 		structure.logEntry = sessionState.LogEntry
 	}
 
-	pool, err := helpers.NewWorkerPool(10, len(allInfos))
-	if err != nil {
-		actionState.AddErrors(errors.Wrap(err, "failed to start worker pool"))
-		return
-	}
+	total := len(allInfos)
+	if total > 0 { // Only start worker pool if we have work to do
+		pool, err := helpers.NewWorkerPool(10, total)
+		if err != nil {
+			actionState.AddErrors(errors.Wrap(err, "failed to start worker pool"))
+			return
+		}
 
-	for _, info := range allInfos {
-		if err := pool.AddTask(func() error {
-			if info == nil {
-				return nil
-			}
+		for _, info := range allInfos {
+			if err := pool.AddTask(func() error {
+				if info == nil {
+					return nil
+				}
 
-			return structure.getStructureForObjectSync(sessionState, actionState, app, info.Id, info.Type, settings.IncludeRaw)
-		}); err != nil {
-			actionState.AddErrors(err)
+				return structure.getStructureForObjectSync(sessionState, actionState, app, info.Id, info.Type, settings.IncludeRaw)
+			}); err != nil {
+				actionState.AddErrors(err)
+			}
 		}
-	}
 
-	for result := range pool.Results() {
-		if result != nil {
-			actionState.AddErrors(result)
+		for result := range pool.Results() {
+			if result != nil {
+				actionState.AddErrors(result)
+			}
 		}
 	}