Appveyor and Windows compat

Author: mikicz

arca/_arca.py

@@ -1,5 +1,6 @@
 import hashlib
 import json
+import platform
 import re
 from collections import defaultdict
 from datetime import datetime
@@ -139,7 +140,22 @@ def validate_repo_url(self, repo: str):
         :raise ValueError: If the URL is not valid
         """
         # that should match valid git repos
-        if not isinstance(repo, str) or not re.match(r"^(https?|file)://[\w._\-/~]*[.git]?/?$", repo):
+        valid = True
+
+        url_regex = re.compile(r"^https?://[\w._\-/~]*[.git]?/?$")
+
+        if not isinstance(repo, str):
+            valid = False
+
+        if platform.system() == "Windows":
+            if not url_regex.match(repo) and not re.match(r"file://(localhost)?/[a-zA-Z]:\\[\\\S|*\S]?.*", repo):
+                valid = False
+
+        else:
+            if not url_regex.match(repo) and not re.match(r"file://[\w._\-/~]*[.git]?/?$", repo):
+                valid = False
+
+        if not valid:
             raise ValueError(f"{repo} is not a valid http[s] or file:// git repository.")
 
     def repo_id(self, repo: str) -> str:

tests/common.py

@@ -1,8 +1,10 @@
 import os
-
+from pathlib import Path
 
 if os.environ.get("TRAVIS", False):
     BASE_DIR = "/home/travis/build/{}/test_loc".format(os.environ.get("TRAVIS_REPO_SLUG", "mikicz/arca"))
+elif os.environ.get("APPVEYOR", False):
+    BASE_DIR = Path(os.environ["APPVEYOR_BUILD_FOLDER"]) / "test_loc"
 else:
     BASE_DIR = "/tmp/arca/test"
 

tests/conftest.py

@@ -1,3 +1,4 @@
+import platform
 import shutil
 import tempfile
 from pathlib import Path
@@ -16,7 +17,12 @@ def create_temp_repo(file) -> TempRepo:
     git_dir = Path(tempfile.mkdtemp())
     repo = Repo.init(str(git_dir))
 
-    return TempRepo(repo, git_dir, f"file://{git_dir}", "master", git_dir / file)
+    file_url = f"file://{git_dir}"
+
+    if platform.system() == "Windows":
+        file_url = f"file:///{git_dir}"
+
+    return TempRepo(repo, git_dir, file_url, "master", git_dir / file)
 
 
 @pytest.fixture()

tests/test_vagrant.py

@@ -11,8 +11,8 @@
 
 
 def test_validation():
-    if os.environ.get("TRAVIS", False):
-        pytest.skip("Vagrant doesn't work on Travis")
+    if os.environ.get("CI", False):
+        pytest.skip("Vagrant doesn't work on CIs")
 
     backend = VagrantBackend()
 
@@ -54,7 +54,7 @@ def test_validation():
 # If you want to test that even init of the VM works, set ``destroy`` to True, it will destroy the previous one as well.
 # Set to ``False`` by default to bootup time and bandwidth.
 def test_vagrant(temp_repo_func, destroy=False):
-    if os.environ.get("TRAVIS", False):
+    if os.environ.get("CI", False):
         pytest.skip("Vagrant doesn't work on Travis")
 
     backend = VagrantBackend(verbosity=2, use_registry_name="docker.io/mikicz/arca-test",