Skip to content

Remove quote marks and styling from badge tagline#4630

Merged
marcoacierno merged 1 commit intomainfrom
claude/remove-badge-quotes-T2cJd
Apr 27, 2026
Merged

Remove quote marks and styling from badge tagline#4630
marcoacierno merged 1 commit intomainfrom
claude/remove-badge-quotes-T2cJd

Conversation

@marcoacierno
Copy link
Copy Markdown
Member

What

Simplified the badge tagline rendering by removing the decorative quote marks (") that surrounded the tagline text. Also removed the associated .badge-tagline-quote CSS class and its font-weight styling that is no longer needed.

The tagline now displays as plain text without quotes, making the component cleaner and reducing unnecessary DOM elements.

ToDo

  • Verify badge appearance in design/preview

https://claude.ai/code/session_01NDkgpco9wHrNPbP9zEru7h

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Apr 27, 2026 6:47pm

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 27, 2026

Removes decorative quote marks from the badge tagline and the associated CSS class.

Check class removal: Before merging, confirm the deleted .badge-tagline-quote CSS class is not referenced in any print scripts, Puppeteer/Playwright configs, or PDF generation pipelines. Given the badge is used for physical printing, a grep across the full repo (including scripts/) would confirm it's safe to delete.

Unchecked TODO: The PR description has an unchecked item to verify badge appearance in design/preview. The badge layout is print-critical (physical conference badges), so this should be verified before merging.

Minor: tagline.substring(0, 250) will throw if tagline is explicitly passed as undefined from a call site (the default empty string only applies when the prop is omitted). Consider tagline?.substring(0, 250) ?? "" as a defensive fix.

@marcoacierno marcoacierno merged commit 1e9f515 into main Apr 27, 2026
6 of 7 checks passed
@marcoacierno marcoacierno deleted the claude/remove-badge-quotes-T2cJd branch April 27, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants