You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Simplified the badge tagline rendering by removing the decorative quote marks (") that surrounded the tagline text. Also removed the associated .badge-tagline-quote CSS class and its font-weight styling that is no longer needed.
The tagline now displays as plain text without quotes, making the component cleaner and reducing unnecessary DOM elements.
Removes decorative quote marks from the badge tagline and the associated CSS class.
Check class removal: Before merging, confirm the deleted .badge-tagline-quote CSS class is not referenced in any print scripts, Puppeteer/Playwright configs, or PDF generation pipelines. Given the badge is used for physical printing, a grep across the full repo (including scripts/) would confirm it's safe to delete.
Unchecked TODO: The PR description has an unchecked item to verify badge appearance in design/preview. The badge layout is print-critical (physical conference badges), so this should be verified before merging.
Minor: tagline.substring(0, 250) will throw if tagline is explicitly passed as undefined from a call site (the default empty string only applies when the prop is omitted). Consider tagline?.substring(0, 250) ?? "" as a defensive fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplified the badge tagline rendering by removing the decorative quote marks (
") that surrounded the tagline text. Also removed the associated.badge-tagline-quoteCSS class and its font-weight styling that is no longer needed.The tagline now displays as plain text without quotes, making the component cleaner and reducing unnecessary DOM elements.
ToDo
https://claude.ai/code/session_01NDkgpco9wHrNPbP9zEru7h