Skip to content

Commit 23e428b

Browse files
DavidLesnjakRobertRostohar
authored andcommitted
SystemView: improve log messages
1 parent 2dc99b0 commit 23e428b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

pyocd/utility/systemview.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ def __init__(self, session: Session, rtt_configs: Dict[int, "RTTConfig"], system
7070
self._systemview = systemview_config
7171
self._files_per_core: Dict[int, List[str]] = {}
7272

73+
if not self._systemview.file:
74+
LOG.debug("No SystemView output file configured; cannot configure SystemView SVDat generation")
75+
return
76+
7377
# Create a list of output files for each core
7478
# and delete any existing files with the same name to ensure clean output for SystemView
7579
fname_root = self._systemview.file.rsplit('.', 1)[0]
@@ -107,7 +111,7 @@ def assemble_file(self) -> bool:
107111
LOG.warning("Failed to remove empty SystemView file '%s'", f)
108112

109113
if not collected_files:
110-
LOG.debug("No temporary SystemView files; skipping SVDat generation.")
114+
LOG.debug("No temporary SystemView files; skipping SVDat generation")
111115
return False
112116

113117
try:
@@ -144,6 +148,8 @@ def assemble_file(self) -> bool:
144148
except OSError:
145149
LOG.warning("Failed to remove SystemView file '%s' after appending", f)
146150
except OSError as e:
147-
raise OSError(f"Failed to open/write SystemView output file {self._systemview.file}: {e}")
151+
LOG.error("Failed to open/write SystemView output file '%s': %s", self._systemview.file, e)
152+
return False
148153

154+
LOG.info("SystemView SVDat file '%s' generated successfully from %d SystemView RTT channels", self._systemview.file, len(collected_files))
149155
return True

0 commit comments

Comments
 (0)