MOAB has dropped FindMOAB_HDF5

[ahnaf-tahmid-chowdhury]

Recently, I noticed that after removing FindHDF5_MOAB, DD is unable to automatically detect HDF5.

-- Found MOAB Version: 5.5.1
-- MOAB_LIBRARIES is -L/usr/local/lib64 -lMOAB /usr/local/lib64/libnetcdf.sohdf5-shared/usr/lib64/libcurl.so
-- MOAB_INCLUDE_DIRS is /usr/local/include/usr/include/eigen3
-- Found Embree 4.3.3 at 
-- EMBREE_LIBRARY is /usr/local/lib64/libembree4.so.4
-- EMBREE_INCLUDE_DIRS is /usr/local/include
-- Found Git: /usr/local/bin/git (found version "2.45.2")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
CMake Warning at docs/CMakeLists.txt:15 (message):
  Doxygen is required to build the documentation for double-down.


-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /root/dd/build
[  8%] Building CXX object CMakeFiles/dd.dir/src/primitives.cpp.o
[  4%] Building CXX object CMakeFiles/dd.dir/src/RTI.cpp.o
[ 12%] Building CXX object CMakeFiles/dd.dir/src/MOABRay.cpp.o
[ 16%] Building CXX object CMakeFiles/dd.dir/src/MOABDirectAccess.cpp.o
[ 20%] Linking CXX shared library libdd.so
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: cannot find -lhdf5-shared: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/dd.dir/build.make:147: libdd.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:164: CMakeFiles/dd.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

[pshriwise]

HDF5 isn't a dependency of double-down directly, but rather a dependency for MOAB. This indicates to me that the problem is in the resulting CMake files provided by the MOAB installation rather than in double-down. The CI here (last run yesterday I believe) also doesn't seem to have trouble compiling with the latest development version of MOAB (presumably a version that also has removed the FindHDF5_MOAB file.

[pshriwise]

Switching to the CMake targets provided by MOAB might be another option to fix this as well, provided that the targets provide the correct information on the location of their dependencies of course.

[shimwell]

I think that I have hit a similar issue when building this manylinux dockerfile

1.596 -- Generating done (0.0s)
1.597 -- Build files have been written to: /root/dd/build
1.622 [  4%] Building CXX object CMakeFiles/dd.dir/src/RTI.cpp.o
1.622 [ 16%] Building CXX object CMakeFiles/dd.dir/src/MOABRay.cpp.o
1.622 [ 16%] Building CXX object CMakeFiles/dd.dir/src/MOABDirectAccess.cpp.o
1.623 [ 16%] Building CXX object CMakeFiles/dd.dir/src/primitives.cpp.o
3.496 [ 20%] Linking CXX shared library libdd.so
3.509 /opt/rh/gcc-toolset-14/root/usr/libexec/gcc/x86_64-redhat-linux/14/ld: cannot find -lhdf5-shared: No such file or directory
3.522 collect2: error: ld returned 1 exit status
3.523 make[2]: *** [CMakeFiles/dd.dir/build.make:151: libdd.so] Error 1
3.524 make[1]: *** [CMakeFiles/Makefile2:193: CMakeFiles/dd.dir/all] Error 2
3.524 make: *** [Makefile:146: all] Error 2