Skip to content

Commit 4d94f50

Browse files
committed
Use shortened names and enable benchmarks on trunk.
A number of the benchmarks I added are now merged into trunk and thus can be run to compare PRs to pre-released versions of the code.
1 parent 3301a4d commit 4d94f50

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
3232
- AggregatorRegistry renamed to ClusterRegistry, old name deprecated
3333
- chore: update faceoff to 1.1
3434
- perf: Stat aggregation uses similar strategy to collection. 60% faster aggregation
35+
- ci: Run additional benchmarks against trunk
3536

3637
### Added
3738

benchmarks/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ const debug = require('debug')('benchmark');
1313
*/
1414

1515
const benchmarks = new Benchmark({
16-
'prom-client@latest': 'prom-client@latest',
17-
'prom-client@trunk': 'git@github.com:siimon/prom-client',
18-
'prom-client@current': { location: process.cwd() },
16+
released: 'prom-client@latest',
17+
trunk: 'git@github.com:siimon/prom-client',
18+
current: { location: process.cwd() },
1919
});
2020

2121
benchmarks.suite('counter', require('./counter'));

benchmarks/util.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const Path = require('path');
55
module.exports = setupUtilSuite;
66

77
function setupUtilSuite(suite) {
8-
const skip = ['prom-client@latest'];
8+
const skip = ['released'];
99

1010
suite.add(
1111
'hashObject',
@@ -57,10 +57,6 @@ function setupUtilSuite(suite) {
5757
suite.add(
5858
'LabelGrouper.keyFrom()',
5959
(client, labelGrouper) => {
60-
if (labelGrouper === undefined) {
61-
return;
62-
}
63-
6460
labelGrouper.keyFrom({
6561
foo: 'longish',
6662
user_agent: 'Chrome',
@@ -77,7 +73,7 @@ function setupUtilSuite(suite) {
7773

7874
return new Util.LabelGrouper();
7975
},
80-
skip: ['prom-client@latest', 'prom-client@trunk'],
76+
skip: ['released', 'trunk'],
8177
},
8278
);
8379
}

0 commit comments

Comments
 (0)