Polish

- handle Not Accepted case, treating the response as plain text
- remove redudent specification of content types and status codes
- add EditorConfig profile

Author: scothis

.editorconfig

@@ -0,0 +1,30 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+# Indentation override for all JS
+[*.js]
+charset = utf-8
+indent_style = space
+indent_size = 4
+
+# Matches the exact files either package.json or .travis.yml
+[{package.json,.travis.yml}]
+indent_style = space
+indent_size = 2
+
+# Ignore node_modules
+[/src/main/node/node_modules/**]
+end_of_line = ignore
+insert_final_newline = ignore
+trim_trailing_whitespace = ignore
+charset = ignore
+indent_style = ignore
+indent_size = ignore

src/main/node/lib/app.js

@@ -29,16 +29,16 @@ function makeApp(fn) {
 
         switch (negotiator.mediaType(SUPPORTED_MEDIA_TYPES)) { // returns the most preferred Accept'ed type intersected with our list
             case 'application/json':
-                res.type("application/json").json(resultx);
+                res.json(resultx);
                 break;
             case 'text/plain':
                 // Force text/plain before calling send, as it defaults to html for strings
-                res.type("text/plain").send("" + resultx);
+                res.type('text/plain').send('' + resultx);
+                break;
+            default:
+                res.status(406).type('text/plain').send('' + resultx);
                 break;
-
         }
-
-        res.status(200);
     }));
 
     // handle errors
@@ -50,4 +50,4 @@ function makeApp(fn) {
     return app;
 }
 
-module.exports = makeApp;
+module.exports = makeApp;

src/main/node/spec/appSpec.js

@@ -62,7 +62,7 @@ describe('app', () => {
         beforeEach(() => {
             app = makeApp(name => `Hello ${name}!`);
         });
-        
+
         it('should respond with plain text', () => {
             return request(app)
                 .post('/')
@@ -121,4 +121,23 @@ describe('app', () => {
                 });
         });
     });
+
+    describe('when nothing is accepted', () => {
+        beforeEach(() => {
+            app = makeApp(name => `Hello ${name}!`);
+        });
+
+        it('should respond with a 406', () => {
+            return request(app)
+                .post('/')
+                .accept('application/vnd.projectriff.bogus')
+                .type('text/plain')
+                .send('riff')
+                .expect(406)
+                .expect('content-type', /plain/)
+                .expect(res => {
+                    expect(res.text).toBe('Hello riff!');
+                });
+        });
+    });
 });