ejaberd support of XEP-0384: OMEMO Encryption v0.9.0 for publish-options errors

[cmeng-git]

Before creating a ticket, please consider if this should fit the discussion forum better.

Environment

• ejabberd version: 25.10
• Erlang version: Eralng/OTP 28 [erts-16.1.1]
• OS: Linux Ubuntu 20.04
• Installed from: source

Configuration (only if needed): grep -Ev '^$|^\s*#' ejabberd.yml

loglevel: 5

  mod_pubsub:
    db_type: sql
    access_createnode: pubsub_createnode
    ## reduces resource comsumption, but XEP incompliant
    ignore_pep_from_offline: true
    ## XEP compliant, but increases resource comsumption
    ## ignore_pep_from_offline: false

    last_item_cache: false
    plugins:
      - flat
      - pep # pep requires mod_caps

    # max_item_expire_node: timeout() | infinity (v21.12)
    # max_items_node: non_neg_integer() | infinity  

    force_node_config:
      ## Change from "whitelist" to "open" to enable OMEMO support
      ## See https://github.com/processone/ejabberd/issues/2425
      "eu.siacs.conversations.axolotl.*":
        access_model: open
      ## Avoid buggy clients to make their bookmarks public
      "storage:bookmarks":
        access_model: whitelist
      ## Jitsi-videobrige statistic for load balancing
      "sharedStatsNode":
        access_model: open

Errors from error.log/crash.log

see aTalk logcats

Bug description

aTalk is trying to implement XEP-0384: OMEMO Encryption v0.9.0 support.

When aTalk is sending the bundles as per example given in
5.3.2 Bundles

08:45:41.772  D  SENT (0): 
                 <iq id='4936H-13' type='set'>
                   <pubsub xmlns='http://jabber.org/protocol/pubsub'>
                     <publish node='urn:xmpp:omemo:2:bundles'>
                       <item id='941623925'>
                         <bundle xmlns='urn:xmpp:omemo:2'>
                           <spk id='9'>
                             BUKKTd7PPqyMdbZKriPc8wLwai4q/LlcJ+om1Wuh951h
                           </spk>
                           <spks>
                             5haUkjE1FRleU+rnya8ViyZwvIyUhIsNtsD6ktY1slX3oAynaCHe2ZFsl0dFRGHjwS3V01wbwz3DJ941wCYohg==
                           </spks>
                           <ik>
                             BXpwuJeVPzZm1R6uvLkaPSuMb5cKOemat2WPjZK6iM0b
                           </ik>
                           <prekeys>
                             <pk id='1'>
                               BdhKJALwGwD0n6ar0VZFCIK7+Tfc30SxZc95S2bdn9Fx
                             </pk>
                             <pk id='2'>
                               BSqv8byuWhOe1mUJ0Z+HLkPPi5lGLAsjN0bVB18GablJ
                             </pk>

                             <pk id='100'>
                               BcW6YMJVNWVVvRAFj02VPqD76G8N6ho9Mzpl2+1tUV41
                             </pk>
                           </prekeys>
                         </bundle>
                       </item>
                     </publish>
                     <publish-options>
                       <x xmlns='jabber:x:data' type='submit'>
                         <field var='FORM_TYPE'>
                           <value>
                             http://jabber.org/protocol/pubsub#publish-options
                           </value>
                         </field>
                         <field var='pubsub#max_items'>
                           <value>
                             100
                           </value>
                         </field>
                         <field var='pubsub#access_model'>
                           <value>
                             open
                           </value>
                         </field>
                       </x>
                     </publish-options>
                   </pubsub>
                 </iq>

ejabberd always return error whenever any of the publish-options field varaibles is send i.e. 'pubsub#max_items' or pubsub#access_model'. The bundle sending works OK if the publish-options element is not included in the stanza.

08:45:42.016  D  RECV (0): 
                 <iq xml:lang='en-US' to='swan@atalk.sytes.net/atalk-1euc7pi' from='swan@atalk.sytes.net' type='error' id='4936H-13'>
                   <pubsub xmlns='http://jabber.org/protocol/pubsub'>
                     <publish node='urn:xmpp:omemo:2:bundles'>
                       <item id='941623925'>
                         <bundle xmlns='urn:xmpp:omemo:2'>
                    ....
                     </publish-options>
                   </pubsub>
                   <error type='cancel'>
                     <precondition-not-met xmlns='http://jabber.org/protocol/pubsub#errors'/>
                     <conflict xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
                   </error>
                 </iq>

Any advice how to resolve the error.