Skip to content

Rename WorkspaceStoreRef.Path to WorkspaceStoreName.Cluster since we don't use the human readable path #174

@aaronschweig

Description

@aaronschweig

Current Situation

type WorkspaceStoreRef struct {
Name string `json:"name"`
Path string `json:"path"`
}

Here we have defined in the spec that a store is referenced by it's name and a Path in KCP this normally means we write the human readable workspace path, e.g root:a:b:c. This is not the case as we can see it in here:

Path: accountInfo.Spec.Organization.OriginClusterId,

There we need to change the spec to properly reflect the value it is holding.

Maybe this could even be a reason for a v1alpha2 and a conversion webhook to smoothen the transition.

Todos

  • Rename WorkspaceStoreRef.Path to WorkspaceStoreRef.Cluster
  • Udpate all the references in the code
  • Run the code generation
  • Update the apiresourceschema in the platform-mesh operator
  • Coordinate the rollout of the change and maybe migrate existing resources

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions