ConstantArrayType: prevent unnecessary work

Author: staabm

src/Type/Constant/ConstantArrayType.php

@@ -564,9 +564,15 @@ public function findTypeAndMethodNames(): array
 				$has->yes()
 				&& !$phpVersion->supportsCallableInstanceMethods()
 			) {
-				$methodReflection = $type->getMethod($methodName->getValue(), new OutOfClassScope());
-				if ($classOrObject->isString()->yes() && !$methodReflection->isStatic()) {
-					continue;
+				$isString = $classOrObject->isString();
+				if ($isString->yes()) {
+					$methodReflection = $type->getMethod($methodName->getValue(), new OutOfClassScope());
+
+					if (!$methodReflection->isStatic()) {
+						continue;
+					}
+				} elseif ($isString->maybe()) {
+					$has = $has->and(TrinaryLogic::createMaybe());
 				}
 			}
 

tests/PHPStan/Rules/Functions/CallCallablesRuleTest.php

@@ -353,4 +353,17 @@ public function testPipeOperator(): void
 		]);
 	}
 
+	public function testMaybeNotCallable(): void
+	{
+		$errors = [];
+		if (PHP_VERSION_ID >= 80000) {
+			$errors[] = [
+				"Trying to invoke array{'MaybeNotCallable\\\Bar'|\$this(MaybeNotCallable\Bar), 'doFoo'} but it might not be a callable.",
+				15,
+			];
+		}
+
+		$this->analyse([__DIR__ . '/data/maybe-not-callable.php'], $errors);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/maybe-not-callable.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace MaybeNotCallable;
+
+class Bar
+{
+	private function doFoo()
+	{
+		echo 'yes';
+	}
+
+	public function doBar()
+	{
+		$cb = [rand(0,1) ? 'MaybeNotCallable\Bar' : $this, 'doFoo'];
+		$cb();
+	}
+}