No need to call rememberConstructorExpressions for each enterClassMethod if rememberConstructorScope is kept

ondrejmirtes · ondrejmirtes · commit 78d946dacc0d · 2026-01-17T15:16:31.000+01:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -2417,8 +2417,8 @@ private function enterFunctionLike(
 		$conditionalTypes = [];
 
 		if ($preserveConstructorScope) {
-			$expressionTypes = $this->rememberConstructorExpressions($this->expressionTypes);
-			$nativeExpressionTypes = $this->rememberConstructorExpressions($this->nativeExpressionTypes);
+			$expressionTypes = $this->expressionTypes;
+			$nativeExpressionTypes = $this->nativeExpressionTypes;
 		}
 
 		foreach ($functionReflection->getParameters() as $parameter) {

Original file line number	Diff line number	Diff line change
`@@ -2417,8 +2417,8 @@ private function enterFunctionLike(`
`2417`	`2417`	`$conditionalTypes = [];`
`2418`	`2418`
`2419`	`2419`	`if ($preserveConstructorScope) {`
`2420`		`- $expressionTypes = $this->rememberConstructorExpressions($this->expressionTypes);`
`2421`		`- $nativeExpressionTypes = $this->rememberConstructorExpressions($this->nativeExpressionTypes);`
	`2420`	`+ $expressionTypes = $this->expressionTypes;`
	`2421`	`+ $nativeExpressionTypes = $this->nativeExpressionTypes;`
`2422`	`2422`	`}`
`2423`	`2423`
`2424`	`2424`	`foreach ($functionReflection->getParameters() as $parameter) {`