clang-tidy: fix cppcoreguidelines-pro-type-member-init

Author: ayushjariyal

.clang-tidy

@@ -18,7 +18,6 @@ Checks: >
     -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
     -cppcoreguidelines-pro-bounds-pointer-arithmetic,
     -cppcoreguidelines-pro-type-const-cast,
-    -cppcoreguidelines-pro-type-member-init,
     -cppcoreguidelines-pro-type-reinterpret-cast,
     -cppcoreguidelines-pro-type-union-access,
     -cppcoreguidelines-pro-type-vararg,

include/chinese/chinesePostman.hpp

@@ -160,7 +160,7 @@ PgrDirectedChPPGraph::PgrDirectedChPPGraph(const std::vector<Edge_t> &dataEdges)
             }
         }
 
-        CostFlow_t edge;
+        CostFlow_t edge{};
         edge.edge_id = e.id;
         edge.reverse_capacity = -1;
         edge.reverse_cost = -1.0;
@@ -185,7 +185,7 @@ PgrDirectedChPPGraph::PgrDirectedChPPGraph(const std::vector<Edge_t> &dataEdges)
         int d = iter->second;
         if (d == 0) continue;
         if (d > 0) totalDeg += d;
-        CostFlow_t edge = {};
+        CostFlow_t edge{};
         edge.reverse_capacity = -1;
         edge.reverse_cost = -1.0;
         edge.cost = 0.0;

include/cpp_common/base_graph.hpp

@@ -720,7 +720,7 @@ class Pgr_base_graph {
       * @return edge data
       */
      T_E get_edge_info(const E &e) const {
-         T_E d_edge;
+         T_E d_edge{};
          d_edge.id = graph[e].id;
          d_edge.source = graph[source(e)].id;
          d_edge.target = graph[target(e)].id;

include/cpp_common/ch_edge.hpp

@@ -63,10 +63,10 @@ class CH_edge {
      friend std::ostream& operator <<(std::ostream& os, const CH_edge& e);
 
  public:
-     int64_t id;
-     int64_t source;
-     int64_t target;
-     double cost;
+     int64_t id{};
+     int64_t source{};
+     int64_t target{};
+     double cost{};
 
  private:
      Identifiers<int64_t> m_contracted_vertices;

include/cpp_common/ch_vertex.hpp

@@ -41,7 +41,7 @@ namespace pgrouting {
 
 class CH_vertex {
  public:
-    int64_t id;
+    int64_t id{};
 
     CH_vertex();
     CH_vertex(const Edge_t &other, bool is_source) :

include/cpp_common/line_vertex.hpp

@@ -93,11 +93,11 @@ class Line_vertex {
      }
 
  public:
-     int64_t id;
-     int64_t vertex_id;
-     int64_t source;
-     int64_t target;
-     double cost;
+     int64_t id{};
+     int64_t vertex_id{};
+     int64_t source{};
+     int64_t target{};
+     double cost{};
 };
 
 }  // namespace pgrouting

include/cpp_common/path.hpp

@@ -57,9 +57,9 @@ class Path {
 
  private:
     std::deque< Path_t > path;
-    int64_t m_start_id;
-    int64_t m_end_id;
-    double m_tot_cost;
+    int64_t m_start_id{};
+    int64_t m_end_id{};
+    double m_tot_cost{};
 
  public:
     Path(): m_start_id(0), m_end_id(0), m_tot_cost(0)

include/lineGraph/lineGraphFull.hpp

@@ -292,7 +292,7 @@ class Pgr_lineGraphFull : public Pgr_base_graph<G, T_V, T_E, t_directed> {
     }
 
  private:
-    int64_t m_num_edges;
+    int64_t m_num_edges{};
     std::map < int64_t, double > m_edge_costs;
     std::map < int64_t, std::pair< int64_t, int64_t > > m_transformation_map;
     std::map < std::pair< int64_t, int64_t >, int64_t > m_vertex_map;

include/max_flow/maxflow.hpp

@@ -193,8 +193,8 @@ class PgrFlowGraph {
      * The same applies for sinks.
      * To avoid code repetition, a supersource/sink is used even in the one to one signature.
      */
-     V supersource;
-     V supersink;
+     V supersource{};
+     V supersink{};
 };
 
 }  // namespace graph

include/max_flow/minCostMaxFlow.hpp

@@ -138,8 +138,8 @@ class PgrCostFlowGraph {
      * The same applies for sinks.
      * To avoid code repetition, a supersource/sink is used even in the one to one signature.
      */
-     V supersource;
-     V supersink;
+     V supersource{};
+     V supersink{};
 };
 
 }  // namespace graph