Skip to content

feature request: region agnostic API input/output #21

@kyoukaya

Description

@kyoukaya

The current API only accepts and uses the Chinese name of items as input and output for item objects, which is troublesome to work around for clients who are region agnostic and work with item IDs internally.

Since many other services use this API as is, I would like to suggest that an optional field, use_item_id, of type boolean indicating that the client wants to have the input and output be item IDs, be added to the API.

Drawbacks:
Since ArkPlanner and penguin-stats uses an item's Chinese name internally, computational work would have to be done to map item IDs to their Chinese name and vice versa. Occasional network traffic would also be incurred to fetch and keep updated the item table for doing so.

I would be happy to put up a PR for this feature if the maintainers are okay with this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions