-
Notifications
You must be signed in to change notification settings - Fork 8
Description
Current Behavior
We are currently storing sequences for the event sequencer as python methods.
Expected Behavior
They are basically just arrays being returned by the methods and don't necessarily need to be stored as individual methods. We could even store them in a dictionary so we can tie a name/label to each sequence that we would like.
Suggested Solution
Store them as dictionaries. Maybe read/write them from YAML files and have a method to make new sequences.
e.g.
sequence_dict=
{'_seq_120hz_yano':[[
['ray1', 1],
['daq_readout', 0]
],
'_seq_60hz':[
['ray0', 1],
['pp_trig', 0],
['ray1', 1],
['daq_readout', 0],
['ray2', 1],
['pp_trig', 0],
['ray3', 1],
['daq_readout', 0]
]
}
and so on. Then seq_put can accept the dictionary name. e.g.:
self._seq_put(self._seq_90hz_yano())
becomes
self._seq_put(sequence_dict['_seq_90hz_yano']) or we have the dictionary lookup within the method and just pass the string name.
The dictionaries could then also store which sync marker they want and so on.