Don't report errors on submodule instantiation failures (Resolve #146)

Author: VonTum

src/errors.rs

@@ -235,7 +235,7 @@ impl<'linker> ErrorCollector<'linker> {
     pub fn did_error(&self) -> bool {
         self.did_error.get()
     }
-    pub fn set_did_error(&mut self) {
+    pub fn set_did_error(&self) {
         self.did_error.set(true);
     }
 }

src/instantiation/concrete_typecheck.rs

@@ -927,8 +927,10 @@ impl<'inst, 'l: 'inst> ModuleTypingContext<'l> {
         let instance = match instance {
             Ok(instance) => instance,
             Err(InstantiateError::ErrorInModule) => {
-                self.errors
-                    .error(submod_instr.get_span(), "Error instantiating submodule");
+                self.errors.set_did_error();
+                // Don't report errors on submodule instantiation erroring. This should reduce the "error overload" certainly in recursive modules. (See #146)
+                /*self.errors
+                .error(submod_instr.get_span(), "Error instantiating submodule");*/
                 return;
             }
             Err(InstantiateError::RecursionLimitExceeded { message }) => {

src/instantiation/instantiator.rs

@@ -250,7 +250,7 @@ fn start_instantiation<'l>(
 
     // Don't instantiate modules that already errored. Otherwise instantiator may crash
     if md.link_info.errors.did_error {
-        let mut errors = ErrorCollector::new_empty(md.link_info.file, linker_files);
+        let errors = ErrorCollector::new_empty(md.link_info.file, linker_files);
         errors.set_did_error();
         let msg = format!("Not Instantiating {name} due to abstract typing errors");
         errors.warn(md.link_info.name_span, msg);
@@ -284,7 +284,7 @@ fn start_instantiation<'l>(
         .collect();
 
     if !submodules_with_abs_type_errors.is_empty() {
-        let mut errors = ErrorCollector::new_empty(md.link_info.file, linker_files);
+        let errors = ErrorCollector::new_empty(md.link_info.file, linker_files);
         errors.set_did_error();
         let mut msg =
             format!("Not Instantiating {name} due to abstract typing errors of submodules:\n");