Check if sync_release PR should warn about koji_build triggering bug (#2550)

Check if `sync_release` PR should warn about `koji_build` triggering bug

Related to #2537.
Merge after packit/packit#2425.

Reviewed-by: Maja Massarini
Reviewed-by: Laura Barcziová

Author: softwarefactory-project-zuul[bot]

packit_service/worker/handlers/distgit.py

@@ -15,7 +15,7 @@
 
 from ogr.abstract import PullRequest, AuthMethod
 from ogr.services.github import GithubService
-from packit.config import JobConfig, JobType, Deployment
+from packit.config import JobConfig, JobType, JobConfigTriggerType, Deployment
 from packit.config import aliases
 from packit.config.package_config import PackageConfig
 from packit.exceptions import (
@@ -268,6 +268,20 @@ def sync_branch(
                 kwargs["tag"] = self.tag
             elif version := self.data.event_dict.get("version"):
                 kwargs["versions"] = [version]
+            # check if there is a Koji build job that should trigger on PR merge
+            kwargs["warn_about_koji_build_triggering_bug"] = False
+            for job in self.package_config.get_job_views():
+                if job.type != JobType.koji_build:
+                    continue
+                if job.trigger != JobConfigTriggerType.commit:
+                    continue
+                if branch not in aliases.get_branches(
+                    *job.dist_git_branches,
+                    default_dg_branch="rawhide",
+                ):
+                    continue
+                kwargs["warn_about_koji_build_triggering_bug"] = True
+                break
             downstream_pr = self.packit_api.sync_release(**kwargs)
         except PackitDownloadFailedException as ex:
             # the archive has not been uploaded to PyPI yet

tests/integration/test_new_hotness_update.py

@@ -223,6 +223,7 @@ def test_new_hotness_update(new_hotness_update, sync_release_model):
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).once()
     flexmock(PackitAPI).should_receive("clean")
 
@@ -396,6 +397,7 @@ def test_new_hotness_update_non_git(new_hotness_update, sync_release_model_non_g
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).once()
     flexmock(PackitAPI).should_receive("clean")
 

tests/integration/test_pr_comment.py

@@ -2707,6 +2707,7 @@ def _get_project(url, *_, **__):
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).once()
     flexmock(PackitAPI).should_receive("clean")
 
@@ -2875,6 +2876,7 @@ def _get_project(url, *_, **__):
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).once()
     flexmock(PackitAPI).should_receive("clean")
 

tests/integration/test_release_event.py

@@ -222,6 +222,7 @@ def test_dist_git_push_release_handle(
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).once()
     flexmock(PackitAPI).should_receive("clean")
 
@@ -365,6 +366,7 @@ def test_dist_git_push_release_handle_multiple_branches(
             pr_description_footer=DistgitAnnouncement.get_announcement(),
             add_new_sources=True,
             fast_forward_merge_branches=set(),
+            warn_about_koji_build_triggering_bug=False,
         ).and_return(pr).once()
 
         flexmock(ProposeDownstreamJobHelper).should_receive(
@@ -516,6 +518,7 @@ def test_dist_git_push_release_handle_one_failed(
                 pr_description_footer=DistgitAnnouncement.get_announcement(),
                 add_new_sources=True,
                 fast_forward_merge_branches=set(),
+                warn_about_koji_build_triggering_bug=False,
             ).and_return(pr).once()
             flexmock(ProposeDownstreamJobHelper).should_receive(
                 "report_status_for_branch"
@@ -540,6 +543,7 @@ def test_dist_git_push_release_handle_one_failed(
                 pr_description_footer=DistgitAnnouncement.get_announcement(),
                 add_new_sources=True,
                 fast_forward_merge_branches=set(),
+                warn_about_koji_build_triggering_bug=False,
             ).and_raise(Exception, f"Failed {model.branch}").once()
             flexmock(ProposeDownstreamJobHelper).should_receive(
                 "report_status_for_branch"
@@ -785,6 +789,7 @@ def test_retry_propose_downstream_task(
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_raise(
         PackitDownloadFailedException, "Failed to download source from example.com"
     ).once()
@@ -899,6 +904,7 @@ def test_dont_retry_propose_downstream_task(
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_raise(
         PackitDownloadFailedException, "Failed to download source from example.com"
     ).once()

tests/unit/test_steve.py

@@ -192,6 +192,7 @@ def test_process_message(event, private, enabled_private_namespaces, success):
         pr_description_footer=DistgitAnnouncement.get_announcement(),
         add_new_sources=True,
         fast_forward_merge_branches=set(),
+        warn_about_koji_build_triggering_bug=False,
     ).and_return(pr).times(1 if success else 0)
     flexmock(shutil).should_receive("rmtree").with_args("")