MD5 and SHA1 checksum header for Artifactory #5742
Closed
skycaptain
started this conversation in
Ideas, Issue Triage, and General discussions
Replies: 1 comment 1 reply
-
|
Implemented by #5743. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This is a follow-up on #752. Artifactory seem to require the SHA256 checksum from the client along with MD5 and SHA1 checksums in the request header. Without all three checksums, Artifactory reports insufficient client checksums. As shown in the screenshot, while the SHA256 is marked as
(Uploaded: Identical), the other checksums are marked as(Uploaded: None):Several possible solutions come to my mind:
checksum_headerinternal/pipe/artifactory, since they're always needed for Artifactory.checksumfunction to the template function map, allow adding the checksums viacustom_headerse.g.:I prefer the last option as it's the simplest to implement without breaking existing features. Adding hashing functions to templates would also enable their use elsewhere—for example, uploading files to object storage using paths like
https://artifacts.example.com/{{ sha256 .ArtifactPath }}/.EDIT: Applied suggestion from #5743 (comment).
Original suggestion
Beta Was this translation helpful? Give feedback.
All reactions