-
Notifications
You must be signed in to change notification settings - Fork 906
Open
Labels
cleanupLow impact changesLow impact changes
Description
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
- I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
- I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue
Is your feature request related to a problem? Please describe.
core/src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php
Lines 83 to 86 in d976ae7
| // XXX: backwards compatible for direct callers that do not know about search_tokens | |
| if ($search_tokens === null) { | |
| $search_tokens = array_filter(explode(' ', $request->get('searchPhrase', 'string', ''))); | |
| } |
Introduced in: 7738d7e
Describe the solution you like
List of all callers in core and plugins to clean this up and remove backwards compat of fetchBindRequest by using the new search_tokens parameter or moving the caller up to searchBase()
Callers
core/src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/ServiceController.php
Lines 168 to 169 in f399b33
| $grid = new UIModelGrid($this->getModel()->templates->template); | |
| return $grid->fetchBindRequest($this->request, ["name", "fileid"], "name"); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
cleanupLow impact changesLow impact changes