Skip to content

Commit 310fe32

Browse files
david-marchandigsilya
authored andcommitted
netdev-dpdk: Remove workarounds for fixed checksum bugs.
net/tap fixes were merged as part of v21.11.6/v22.11.4/v23.11 DPDK LTS versions. A net/txgbe fix was merged as part of v21.11.9/v22.11.7/v23.11.3/v24.11 DPDK LTS versions. We can remove the capability filtering workarounds now that OVS main branch requires at least v24.11. Link: https://git.dpdk.org/dpdk/commit/drivers/net/tap?id=0bbafe48ae0a Link: https://git.dpdk.org/dpdk/commit/drivers/net/txgbe?id=25fe1c780d39 Acked-by: Mike Pattrick <mkp@redhat.com> Signed-off-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
1 parent 0efebaf commit 310fe32

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

lib/netdev-dpdk.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1359,26 +1359,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
13591359
dev->hw_ol_features &= ~NETDEV_RX_HW_SCATTER;
13601360
}
13611361

1362-
if (!strcmp(info.driver_name, "net_tap")) {
1363-
/* FIXME: L4 checksum offloading is broken in DPDK net/tap driver.
1364-
* This workaround can be removed once the fix makes it to a DPDK
1365-
* LTS release used by OVS. */
1366-
VLOG_INFO("%s: disabled Tx L4 checksum offloads for a net/tap port.",
1367-
netdev_get_name(&dev->up));
1368-
info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_UDP_CKSUM;
1369-
info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM;
1370-
}
1371-
1372-
if (!strcmp(info.driver_name, "net_txgbe")) {
1373-
/* FIXME: Driver advertises the capability but doesn't seem
1374-
* to actually support it correctly. Can remove this once
1375-
* the driver is fixed on DPDK side. */
1376-
VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a "
1377-
"net/txgbe port.",
1378-
netdev_get_name(&dev->up));
1379-
info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
1380-
}
1381-
13821362
if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
13831363
dev->hw_ol_features |= NETDEV_TX_IPV4_CKSUM_OFFLOAD;
13841364
} else {

0 commit comments

Comments
 (0)