Skip to content

Commit 123798f

Browse files
david-marchandkevintraynor
authored andcommitted
sparse: Remove wrappers for some DPDK headers.
Since sparse v0.6.4 (which is 3 years old and happens to be the latest official release), GCC atomic builtins are recognised by sparse (see below first three links). In the case of rte_atomic.h, DPDK stopped using __sync in favor of __atomic builtin in v23.07 (see below last link). However, no OVS developer complained about sparse build failures because of rte_atomic.h which means that everyone uses a recent sparse (if any). Remove wrappers around those DPDK headers. Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=cf8f104749f5 Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=7cdf84691f33 Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=f42e2afa9ed0 Link: https://git.dpdk.org/dpdk/commit/?id=a2f807316dae Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
1 parent 4721438 commit 123798f

File tree

5 files changed

+1
-86
lines changed

5 files changed

+1
-86
lines changed

Documentation/intro/install/general.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ other than plain text, only if you have the following:
166166
If you are going to extensively modify Open vSwitch, consider installing the
167167
following to obtain better warnings:
168168

169-
- "sparse" version 0.6.2 or later
169+
- "sparse" version 0.6.4 or later
170170
(https://git.kernel.org/pub/scm/devel/sparse/sparse.git/).
171171

172172
- GNU make.

include/sparse/automake.mk

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ noinst_HEADERS += \
1212
include/sparse/netinet/ip6.h \
1313
include/sparse/netpacket/packet.h \
1414
include/sparse/pthread.h \
15-
include/sparse/rte_atomic.h \
16-
include/sparse/rte_mbuf.h \
1715
include/sparse/rte_memcpy.h \
18-
include/sparse/rte_trace_point.h \
1916
include/sparse/sys/socket.h \
2017
include/sparse/sys/sysmacros.h \
2118
include/sparse/sys/types.h \

include/sparse/rte_atomic.h

Lines changed: 0 additions & 25 deletions
This file was deleted.

include/sparse/rte_mbuf.h

Lines changed: 0 additions & 29 deletions
This file was deleted.

include/sparse/rte_trace_point.h

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)