Improve selection and navigation of fields for emv-viewer

* Use currentItemChanged signal instead of itemPressed signal to ensure
  that highlighting of the associated input and display of the
  description occurs even when the tree item is selected during
  searching or via keyboard navigation
* Let all tree items be selectable

Author: leonlynch

viewer/emv-viewer-mainwindow.cpp

@@ -518,10 +518,10 @@ void EmvViewerMainWindow::on_treeView_populateItemsCompleted(
 	QMainWindow::statusBar()->showMessage(msg);
 }
 
-void EmvViewerMainWindow::on_treeView_itemPressed(QTreeWidgetItem* item, int column)
+void EmvViewerMainWindow::on_treeView_currentItemChanged(QTreeWidgetItem* current, QTreeWidgetItem* previous)
 {
-	if (item->type() == EmvTreeItemType) {
-		EmvTreeItem* etItem = reinterpret_cast<EmvTreeItem*>(item);
+	if (current && current->type() == EmvTreeItemType) {
+		EmvTreeItem* etItem = reinterpret_cast<EmvTreeItem*>(current);
 
 		// Highlight selected item in input data. Note that rehighlight() will
 		// also trigger the textChanged() signal and therefore signals must be

viewer/emv-viewer-mainwindow.h

@@ -71,7 +71,7 @@ private slots: // connect-by-name helper functions
 	void on_decodeObjectsCheckBox_stateChanged(int state);
 	void on_searchDescriptionsCheckBox_stateChanged(int state);
 	void on_treeView_populateItemsCompleted(unsigned int validBytes, unsigned int fieldCount, unsigned int invalidChars);
-	void on_treeView_itemPressed(QTreeWidgetItem* item, int column);
+	void on_treeView_currentItemChanged(QTreeWidgetItem* current, QTreeWidgetItem* previous);
 	void on_treeView_itemCopyClicked(QTreeWidgetItem* item);
 	void on_actionCopyAll_triggered();
 	void on_actionFind_triggered();

viewer/emvtreeitem.cpp

@@ -437,7 +437,7 @@ static QTreeWidgetItem* addValueDol(
 		)
 	);
 	dolItem->setExpanded(true);
-	dolItem->setFlags(Qt::ItemIsEnabled);
+	dolItem->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);
 
 	r = emv_dol_itr_init(ptr, len, &itr);
 	if (r) {
@@ -454,7 +454,7 @@ static QTreeWidgetItem* addValueDol(
 				buildFieldString(info, entry.length)
 			)
 		);
-		valueItem->setFlags(Qt::ItemNeverHasChildren | Qt::ItemIsEnabled);
+		valueItem->setFlags(Qt::ItemNeverHasChildren | Qt::ItemIsEnabled | Qt::ItemIsSelectable);
 	}
 	if (r < 0) {
 		qDebug("emv_dol_itr_next() failed; r=%d", r);
@@ -480,7 +480,7 @@ static QTreeWidgetItem* addValueTagList(
 		)
 	);
 	tlItem->setExpanded(true);
-	tlItem->setFlags(Qt::ItemIsEnabled);
+	tlItem->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);
 
 	while ((r = iso8825_ber_tag_decode(ptr, len, &tag)) > 0) {
 		EmvTlvInfo info(tag);
@@ -491,7 +491,7 @@ static QTreeWidgetItem* addValueTagList(
 				buildFieldString(info)
 			)
 		);
-		valueItem->setFlags(Qt::ItemNeverHasChildren | Qt::ItemIsEnabled);
+		valueItem->setFlags(Qt::ItemNeverHasChildren | Qt::ItemIsEnabled | Qt::ItemIsSelectable);
 
 		// Advance
 		ptr = static_cast<const char*>(ptr) + r;