chore: mypy/pylint fixes

Author: bradenmacdonald

src/openedx_catalog/api_impl.py

@@ -5,9 +5,8 @@
 import logging
 from typing import overload
 
-from django.conf import settings
 from opaque_keys.edx.keys import CourseKey
-from organizations.api import ensure_organization
+from organizations.api import ensure_organization  # type: ignore[import]
 from organizations.api import exceptions as org_exceptions
 
 from .models import CatalogCourse, CourseRun

src/openedx_catalog/models/catalog_course.py

@@ -136,15 +136,15 @@ def language_short(self) -> str:
         return self.language[:2]  # Strip locale
 
     @language_short.setter
-    def language_short(self, legacy_code: str) -> str:
+    def language_short(self, legacy_code: str) -> None:
         """
         Set the language code used by this catalog course, without locale.
         This is always a two-digit code, except for Mandarin and Cantonese.
         (This should be a value from settings.ALL_LANGUAGES, and should match
          the CourseOverview.language field.)
         """
         if hasattr(settings, "ALL_LANGUAGES"):
-            assert legacy_code in [code for (code, _name) in settings.ALL_LANGUAGES]
+            assert legacy_code in [code for (code, _name) in settings.ALL_LANGUAGES]  # type: ignore
         if legacy_code == "zh_HANS":  # Mandarin / Simplified
             self.language = "zh-cn"  # Chinese (Mainland China)
         elif legacy_code == "zh_HANT":  # Cantonese / Traditional

src/openedx_catalog/models_api.py

@@ -6,4 +6,5 @@
 See the `openedx_catalog.api` docstring for much more details.
 """
 
+# pylint: disable=unused-import
 from .models import CatalogCourse, CourseRun

tests/openedx_catalog/test_api.py

@@ -14,7 +14,6 @@
 from openedx_catalog import api
 from openedx_catalog.models_api import CatalogCourse, CourseRun
 
-
 pytestmark = pytest.mark.django_db