bug: when the foreacst checks run, don't send urgent message unless need to

[peterdudfield]

Currently when the forecast check runs, it always sends an urgency message

It should only send this, if no forecast has run for the last 2 hours - link

https://github.com/openclimatefix/airflow-dags/blob/main/src/airflow_dags/dags/uk/forecast-gsp-dag.py#L105

I think the way to solve this, is to pass back a urgency of critical or subcritical into here

[prashantpandeygit]

@peterdudfield can i get this assigned? thanks!

[prashantpandeygit]

@peterdudfield the check_forecast_status() function returns a message only for now, so can we change the response to a dict that will return [message,urgency] ? and then based on that message can be sent ??

[peterdudfield]

Yes, so return [message,urgency]

but will need to also pass the message that into here. The message into additional_message_context and urgency into urgency, see 193 for example

[prashantpandeygit]

@peterdudfield can we add another function inside gsp_forecast_pvnet_dag() that pulls urgency type from XCom during runtime itself and send to slack?

[Sukh-P]

Reopening this issue as the problem doesn't seem to be fixed as this behaviour was seen again recently on slack that this message was sent to our critical alerts slack channel rather than sub critical

[CodeVishal-17]

Thanks for reopening — agreed this still isn’t behaving as expected.

From the recent Slack alert, it looks like the urgency is still defaulting to critical somewhere downstream, even when the forecast check should be returning subcritical.

To debug this, I suggest we:

Verify what (message, urgency) is actually being pushed to XCom by check_forecast_status().

Confirm that gsp_forecast_pvnet_dag() is only reading urgency from XCom at runtime, and not falling back to a default.

Add a short log before the Slack send step to print the resolved urgency + channel mapping.

My suspicion is that the Slack send helper is either:

defaulting to critical when urgency is missing/None, or

not correctly mapping subcritical → subcritical channel.

Happy to take a look and open a follow-up PR once we pinpoint which step is overriding the urgency.

[peterdudfield]

Ive added some print statments in the get_slack_message_callback to see whats going on.
Sorry @CodeVishal-17 this might have to be an internal issue as its hard to run as an open source contributor

[CodeVishal-17]

Okay, no worries — thanks for checking into it 👍

If this turns out to be something I can help with from the OSS side, feel free to let me know.

[prashantpandeygit]

Sorry that my PR did not fix the issue.

just for internal reference this commit could help as i used a function which explicitly used to set the channel, it just has string and enum conflit that needs to be checked for: c435c67

hope this would help, and sorry again for the no fix.