-
Notifications
You must be signed in to change notification settings - Fork 938
Deprecate Zipkin exporter #7974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Zipkin exporter #7974
Conversation
d38d30b to
6bc46a9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7974 +/- ##
=========================================
Coverage 90.16% 90.16%
Complexity 7478 7478
=========================================
Files 836 836
Lines 22550 22550
Branches 2224 2224
=========================================
Hits 20333 20333
Misses 1515 1515
Partials 702 702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think we should just mark the zipkin exporter as deprecated for now and come back to the problem of removing shared internal code later. There are a couple of things we could do with the shared internal code which don't involve copying into the zipkin exporter:
|
5c1ee8b to
ba8c91c
Compare
|
@jack-berg I've updated the PR to remove copying to internal code. |
...pkin/src/main/java/io/opentelemetry/exporter/zipkin/internal/ZipkinSpanExporterProvider.java
Show resolved
Hide resolved
jkwatson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jack-berg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thank you for your contribution @michaeljohnalbers! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Deprecates the Zipkin exporter and removes all dependencies on internal classes. This involved copying several classes into a sub-package of the Zipkin exporter package. There is a README.md in this package with a short explanation. Several test classes had to be updated to handle the deprecation.
First part of implementing #7863