Skip to content

Conversation

@michaeljohnalbers
Copy link
Contributor

@michaeljohnalbers michaeljohnalbers commented Jan 9, 2026

Deprecates the Zipkin exporter and removes all dependencies on internal classes. This involved copying several classes into a sub-package of the Zipkin exporter package. There is a README.md in this package with a short explanation. Several test classes had to be updated to handle the deprecation.

First part of implementing #7863

@michaeljohnalbers michaeljohnalbers requested a review from a team as a code owner January 9, 2026 22:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 9, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@michaeljohnalbers michaeljohnalbers force-pushed the deprecate-zipkin-exporter-7863 branch from d38d30b to 6bc46a9 Compare January 9, 2026 23:14
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (d6ad3ae) to head (5d21c39).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7974   +/-   ##
=========================================
  Coverage     90.16%   90.16%           
  Complexity     7478     7478           
=========================================
  Files           836      836           
  Lines         22550    22550           
  Branches       2224     2224           
=========================================
  Hits          20333    20333           
  Misses         1515     1515           
  Partials        702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg
Copy link
Member

I think we should just mark the zipkin exporter as deprecated for now and come back to the problem of removing shared internal code later.

There are a couple of things we could do with the shared internal code which don't involve copying into the zipkin exporter:

  • Promote those classes to our public API
  • Carve out a new category of packages, maybe called *.tools.* or *.utils.*, which we guarantee from an API compatibility standpoint, but advertise as "not for public consumption". Move the shared internal code to this new category of packages.

@michaeljohnalbers michaeljohnalbers force-pushed the deprecate-zipkin-exporter-7863 branch from 5c1ee8b to ba8c91c Compare January 17, 2026 18:07
@michaeljohnalbers
Copy link
Contributor Author

@jack-berg I've updated the PR to remove copying to internal code.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit ee277ae into open-telemetry:main Jan 20, 2026
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Jan 20, 2026

Thank you for your contribution @michaeljohnalbers! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants