Skip to content

Commit 7a5cab3

Browse files
authored
Merge pull request #221 from open-runtimes/fix-make-executor-test-non-final
fix: make executor test non final
2 parents cacb3e8 + d9958f1 commit 7a5cab3

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

rector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
declare(strict_types=1);
44

55
use Rector\Config\RectorConfig;
6+
use Rector\Privatization\Rector\Class_\FinalizeTestCaseClassRector;
67

78
return RectorConfig::configure()
89
->withPaths([
@@ -11,6 +12,9 @@
1112
__DIR__ . '/tests'
1213
])
1314
->withSkipPath(__DIR__ . '/tests/resources')
15+
->withSkip([
16+
FinalizeTestCaseClassRector::class,
17+
])
1418
->withPhpSets(php84: true)
1519
->withComposerBased(phpunit: true)
1620
->withPreparedSets(

tests/e2e/ExecutorTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// TODO: Lengthy log test
1414
// TODO: Lengthy body test
1515

16-
final class ExecutorTest extends TestCase
16+
class ExecutorTest extends TestCase
1717
{
1818
protected string $endpoint = 'http://executor/v1';
1919

@@ -393,8 +393,8 @@ public function testExecute(): void
393393
$this->assertEquals(201, $response['headers']['status-code']);
394394

395395
$response = $this->client->call(Client::METHOD_POST, '/runtimes/test-exec/executions');
396-
$this->assertEquals(200, $response['headers']['status-code']);
397-
$this->assertEquals(200, $response['body']['statusCode']);
396+
$this->assertEquals(200, $response['headers']['status-code'], 'Failed to execute runtime, response ' . json_encode($response, JSON_PRETTY_PRINT));
397+
$this->assertEquals(200, $response['body']['statusCode'], 'Failed execute runtime, response ' . json_encode($response, JSON_PRETTY_PRINT));
398398
$this->assertEquals('aValue', \json_decode((string) $response['body']['headers'], true)['x-key']);
399399

400400
/** Execute on cold-started runtime */

0 commit comments

Comments
 (0)