undo whitespace changes

Author: holyfuchs

internal/cadence/lint_test.go

@@ -46,6 +46,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("lints file with no issues", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "NoError.cdc")
@@ -67,6 +68,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("lints file with import", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "foo/WithImports.cdc")
@@ -89,6 +91,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("lints multiple files", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "NoError.cdc", "foo/WithImports.cdc")
@@ -114,6 +117,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("lints file with warning", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "LintWarning.cdc")
@@ -159,6 +163,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("lints file with error", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "LintError.cdc")
@@ -200,6 +205,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("generates synthetic replacement for replacement category diagnostics", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "ReplacementHint.cdc")
@@ -226,6 +232,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("linter resolves imports from flowkit state", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "WithFlowkitImport.cdc")
@@ -247,6 +254,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("resolves stdlib imports contracts", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "StdlibImportsContract.cdc")
@@ -280,6 +288,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("resolves stdlib imports transactions", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "StdlibImportsTransaction.cdc")
@@ -313,6 +322,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("resolves stdlib imports scripts", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "StdlibImportsScript.cdc")
@@ -322,8 +332,18 @@ func Test_Lint(t *testing.T) {
 			&lintResult{
 				Results: []fileResult{
 					{
-						FilePath:    "StdlibImportsScript.cdc",
-						Diagnostics: []analysis.Diagnostic{},
+						FilePath: "StdlibImportsScript.cdc",
+						Diagnostics: []analysis.Diagnostic{
+							{
+								Location: common.StringLocation("StdlibImportsScript.cdc"),
+								Category: "security",
+								Message:  "hardcoded address detected — consider using named address imports for portability",
+								Range: ast.Range{
+									StartPos: ast.Position{Offset: 109, Line: 5, Column: 37},
+									EndPos:   ast.Position{Offset: 112, Line: 5, Column: 40},
+								},
+							},
+						},
 					},
 				},
 				exitCode: 0,
@@ -334,6 +354,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("resolves stdlib imports Crypto", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "StdlibImportsCrypto.cdc")
@@ -355,6 +376,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("resolves nested imports when contract imported by name", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockState(t)
 
 		results, err := lintFiles(state, false, "TransactionImportingContractWithNestedImports.cdc")
@@ -376,6 +398,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("allows access(account) when contracts on same account", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockStateWithAccountAccess(t)
 
 		results, err := lintFiles(state, false, "ContractA.cdc")
@@ -398,6 +421,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("denies access(account) when contracts on different accounts", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockStateWithAccountAccess(t)
 
 		results, err := lintFiles(state, false, "ContractC.cdc")
@@ -413,6 +437,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("allows access(account) when dependencies on same account (peak-money repro)", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockStateWithDependencies(t)
 
 		results, err := lintFiles(state, false, "imports/testaddr/DepA.cdc")
@@ -435,6 +460,7 @@ func Test_Lint(t *testing.T) {
 
 	t.Run("allows access(account) when dependencies have Source but no Aliases", func(t *testing.T) {
 		t.Parallel()
+
 		state := setupMockStateWithSourceOnly(t)
 
 		// Verify that AddDependencyAsContract automatically adds Source to Aliases
@@ -561,11 +587,11 @@ func setupMockState(t *testing.T) *flowkit.State {
 	_ = afero.WriteFile(mockFs, "Helper.cdc", []byte(`
 	access(all) contract Helper {
 		access(all) let name: String
-
+		
 		init() {
 			self.name = "Helper"
 		}
-
+		
 		access(all) fun greet(): String {
 			return "Hello from ".concat(self.name)
 		}
@@ -574,7 +600,7 @@ func setupMockState(t *testing.T) *flowkit.State {
 
 	_ = afero.WriteFile(mockFs, "ContractWithNestedImports.cdc", []byte(`
 	import Helper from "./Helper.cdc"
-
+	
 	access(all) contract ContractWithNestedImports {
 		access(all) fun test(): String {
 			return Helper.greet()
@@ -585,7 +611,7 @@ func setupMockState(t *testing.T) *flowkit.State {
 
 	_ = afero.WriteFile(mockFs, "TransactionImportingContractWithNestedImports.cdc", []byte(`
 	import ContractWithNestedImports from "ContractWithNestedImports"
-
+	
 	transaction() {
 		prepare(signer: auth(Storage) &Account) {
 			log(ContractWithNestedImports.test())
@@ -631,7 +657,7 @@ func setupMockStateWithAccountAccess(t *testing.T) *flowkit.State {
 	// ContractA imports and calls ContractB's account function - should work (same account)
 	_ = afero.WriteFile(mockFs, "ContractA.cdc", []byte(`
 	import ContractB from "ContractB"
-
+	
 	access(all) contract ContractA {
 		access(all) fun callB() {
 			ContractB.accountOnlyFunction()
@@ -643,7 +669,7 @@ func setupMockStateWithAccountAccess(t *testing.T) *flowkit.State {
 	// ContractC imports and calls ContractB's account function - should fail (different account)
 	_ = afero.WriteFile(mockFs, "ContractC.cdc", []byte(`
 	import ContractB from "ContractB"
-
+	
 	access(all) contract ContractC {
 		access(all) fun callB() {
 			ContractB.accountOnlyFunction()
@@ -718,7 +744,7 @@ func setupMockStateWithDependencies(t *testing.T) *flowkit.State {
 	// DepA imports and calls DepB's account function (like FlowEVMBridgeConfig)
 	_ = afero.WriteFile(mockFs, "imports/testaddr/DepA.cdc", []byte(`
 	import DepB from "DepB"
-
+	
 	access(all) contract DepA {
 		access(all) fun callDepB(forType: Type) {
 			DepB.pauseConfig(forType: forType)
@@ -817,7 +843,7 @@ func setupMockStateWithSourceOnly(t *testing.T) *flowkit.State {
 	// SourceA imports and calls SourceB's account function
 	_ = afero.WriteFile(mockFs, "imports/testaddr/SourceA.cdc", []byte(`
 	import SourceB from "SourceB"
-
+	
 	access(all) contract SourceA {
 		access(all) fun callSourceB() {
 			SourceB.sourceOnlyFunction()