undo whitespace changes

Author: holyfuchs

internal/cadence/lint_test.go

@@ -45,8 +45,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("lints file with no issues", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "NoError.cdc")
 		require.NoError(t, err)
@@ -66,8 +66,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("lints file with import", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "foo/WithImports.cdc")
 		require.NoError(t, err)
@@ -88,8 +88,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("lints multiple files", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "NoError.cdc", "foo/WithImports.cdc")
 		require.NoError(t, err)
@@ -113,8 +113,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("lints file with warning", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "LintWarning.cdc")
 		require.NoError(t, err)
@@ -158,8 +158,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("lints file with error", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "LintError.cdc")
 		require.NoError(t, err)
@@ -199,8 +199,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("generates synthetic replacement for replacement category diagnostics", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "ReplacementHint.cdc")
 		require.NoError(t, err)
@@ -225,8 +225,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("linter resolves imports from flowkit state", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "WithFlowkitImport.cdc")
 		require.NoError(t, err)
@@ -246,8 +246,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("resolves stdlib imports contracts", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "StdlibImportsContract.cdc")
 		require.NoError(t, err)
@@ -279,8 +279,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("resolves stdlib imports transactions", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "StdlibImportsTransaction.cdc")
 		require.NoError(t, err)
@@ -312,8 +312,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("resolves stdlib imports scripts", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "StdlibImportsScript.cdc")
 		require.NoError(t, err)
@@ -333,8 +333,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("resolves stdlib imports Crypto", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "StdlibImportsCrypto.cdc")
 		require.NoError(t, err)
@@ -354,8 +354,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("resolves nested imports when contract imported by name", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockState(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "TransactionImportingContractWithNestedImports.cdc")
 		require.NoError(t, err)
@@ -375,8 +375,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("allows access(account) when contracts on same account", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockStateWithAccountAccess(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "ContractA.cdc")
 		require.NoError(t, err)
@@ -397,8 +397,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("denies access(account) when contracts on different accounts", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockStateWithAccountAccess(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "ContractC.cdc")
 		require.NoError(t, err)
@@ -412,8 +412,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("allows access(account) when dependencies on same account (peak-money repro)", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockStateWithDependencies(t)
+		t.Parallel()
 
 		results, err := lintFiles(state, false, "imports/testaddr/DepA.cdc")
 		require.NoError(t, err)
@@ -434,8 +434,8 @@ func Test_Lint(t *testing.T) {
 	})
 
 	t.Run("allows access(account) when dependencies have Source but no Aliases", func(t *testing.T) {
-		t.Parallel()
 		state := setupMockStateWithSourceOnly(t)
+		t.Parallel()
 
 		// Verify that AddDependencyAsContract automatically adds Source to Aliases
 		sourceAContract, _ := state.Contracts().ByName("SourceA")
@@ -466,6 +466,7 @@ func Test_Lint(t *testing.T) {
 }
 
 func setupMockState(t *testing.T) *flowkit.State {
+	t.Helper()
 	// Mock file system
 	mockFs := afero.NewMemMapFs()
 	_ = afero.WriteFile(mockFs, "NoError.cdc", []byte(`
@@ -615,6 +616,7 @@ func setupMockState(t *testing.T) *flowkit.State {
 }
 
 func setupMockStateWithAccountAccess(t *testing.T) *flowkit.State {
+	t.Helper()
 	// Mock file system
 	mockFs := afero.NewMemMapFs()
 
@@ -702,6 +704,7 @@ func setupMockStateWithAccountAccess(t *testing.T) *flowkit.State {
 }
 
 func setupMockStateWithDependencies(t *testing.T) *flowkit.State {
+	t.Helper()
 	// Reproduce peak-money structure: dependencies with aliases, not contracts
 	mockFs := afero.NewMemMapFs()
 
@@ -801,6 +804,7 @@ func setupMockStateWithDependencies(t *testing.T) *flowkit.State {
 }
 
 func setupMockStateWithSourceOnly(t *testing.T) *flowkit.State {
+	t.Helper()
 	// Test dependencies with ONLY Source (no Aliases) to see if we need to check Source
 	mockFs := afero.NewMemMapFs()