remove portal

Author: mcm-odoo

src/compiler/code_generator.ts

@@ -17,7 +17,6 @@ import {
   ASTTif,
   ASTTKey,
   ASTTOut,
-  ASTTPortal,
   ASTTranslation,
   ASTTranslationContext,
   ASTTSet,
@@ -461,8 +460,6 @@ export class CodeGenerator {
         return this.compileTTranslation(ast, ctx);
       case ASTType.TTranslationContext:
         return this.compileTTranslationContext(ast, ctx);
-      case ASTType.TPortal:
-        return this.compileTPortal(ast, ctx);
     }
   }
 
@@ -1332,26 +1329,4 @@ export class CodeGenerator {
     }
     return null;
   }
-  compileTPortal(ast: ASTTPortal, ctx: Context): string {
-    this.helpers.add("Portal");
-
-    let { block } = ctx;
-    const name = this.compileInNewTarget("slot", ast.content, ctx);
-    let id = generateId("comp");
-    this.helpers.add("createComponent");
-    this.staticDefs.push({
-      id,
-      expr: `createComponent(app, null, false, true, false, false)`,
-    });
-
-    const target = compileExpr(ast.target);
-    const key = this.generateComponentKey();
-    const blockString = `${id}({target: ${target},slots: {'default': {__render: ${name}.bind(this), __ctx: ctx}}}, ${key}, node, ctx, Portal)`;
-    if (block) {
-      this.insertAnchor(block);
-    }
-    block = this.createBlock(block, "multi", ctx);
-    this.insertBlock(blockString, block, { ...ctx, forceNewBlock: false });
-    return block.varName;
-  }
 }

src/compiler/parser.ts

@@ -27,7 +27,6 @@ export const enum ASTType {
   TCallBlock,
   TTranslation,
   TTranslationContext,
-  TPortal,
 }
 
 export interface BaseAST {
@@ -182,12 +181,6 @@ export interface ASTTranslationContext extends BaseAST {
   translationCtx: string;
 }
 
-export interface ASTTPortal extends BaseAST {
-  type: ASTType.TPortal;
-  target: string;
-  content: AST;
-}
-
 export type AST =
   | ASTText
   | ASTComment
@@ -205,8 +198,7 @@ export type AST =
   | ASTLog
   | ASTDebug
   | ASTTranslation
-  | ASTTranslationContext
-  | ASTTPortal;
+  | ASTTranslationContext;
 
 // -----------------------------------------------------------------------------
 // Parser
@@ -252,7 +244,6 @@ function parseNode(node: Node, ctx: ParsingContext): AST | null {
     parseTDebugLog(node, ctx) ||
     parseTForEach(node, ctx) ||
     parseTIf(node, ctx) ||
-    parseTPortal(node, ctx) ||
     parseTTranslation(node, ctx) ||
     parseTTranslationContext(node, ctx) ||
     parseTCall(node, ctx) ||
@@ -934,30 +925,6 @@ function parseTTranslationContext(node: Element, ctx: ParsingContext): AST | nul
   return wrapInTTranslationContextAST(result, translationCtx);
 }
 
-// -----------------------------------------------------------------------------
-// Portal
-// -----------------------------------------------------------------------------
-
-function parseTPortal(node: Element, ctx: ParsingContext): AST | null {
-  if (!node.hasAttribute("t-portal")) {
-    return null;
-  }
-  const target = node.getAttribute("t-portal")!;
-  node.removeAttribute("t-portal");
-  const content = parseNode(node, ctx);
-  if (!content) {
-    return {
-      type: ASTType.Text,
-      value: "",
-    };
-  }
-  return {
-    type: ASTType.TPortal,
-    target,
-    content,
-  };
-}
-
 // -----------------------------------------------------------------------------
 // helpers
 // -----------------------------------------------------------------------------

src/runtime/portal.ts

@@ -4,7 +4,6 @@ import { BDom, createCatcher, multi, text, toggler } from "../blockdom";
 import { html } from "../blockdom/index";
 import { Component } from "../component";
 import { ComponentNode } from "../component_node";
-import { Portal } from "../portal";
 import { markRaw } from "../reactivity/proxy";
 import { Markup } from "../utils";
 import { Fiber } from "./fibers";
@@ -281,6 +280,5 @@ export const helpers = {
   createRef,
   modelExpr,
   createComponent,
-  Portal,
   callTemplate,
 };

src/runtime/rendering/template_helpers.ts

@@ -3,7 +3,6 @@ import { parseXML } from "../common/utils";
 import { compile, CustomDirectives, Template, TemplateFunction } from "../compiler";
 import { comment, createBlock, html, list, multi, text, toggler } from "./blockdom";
 import { getContext } from "./context";
-import { portalTemplate } from "./portal";
 import { helpers } from "./rendering/template_helpers";
 
 const bdom = { text, createBlock, list, multi, html, toggler, comment };
@@ -129,5 +128,3 @@ export function xml(...args: Parameters<typeof String.raw>) {
 }
 
 xml.nextId = 1;
-
-TemplateSet.registerTemplate("__portal__", portalTemplate);

src/runtime/template_set.ts

@@ -2107,29 +2107,4 @@ describe("qweb parser", () => {
       ns: null,
     });
   });
-
-  // ---------------------------------------------------------------------------
-  // t-portal
-  // ---------------------------------------------------------------------------
-  test("t-portal", async () => {
-    expect(parse(`<t t-portal="target">Content</t>`)).toEqual({
-      type: ASTType.TPortal,
-      target: "target",
-      content: { type: ASTType.Text, value: "Content" },
-    });
-  });
-
-  test("t-portal with t-if", async () => {
-    expect(parse(`<t t-portal="target" t-if="condition">Content</t>`)).toEqual({
-      condition: "condition",
-      content: {
-        content: { type: ASTType.Text, value: "Content" },
-        target: "target",
-        type: ASTType.TPortal,
-      },
-      tElif: null,
-      tElse: null,
-      type: ASTType.TIf,
-    });
-  });
 });