prettier + fix test

Author: ged-odoo

package-lock.json

@@ -1,6 +1,6 @@
 import { batched } from "../utils";
 
-export interface ReactiveValue<TRead, TWrite=TRead> {
+export interface ReactiveValue<TRead, TWrite = TRead> {
   (): TRead;
   /**
    * Update the value of the reactive with a new value. If the new value is different

src/runtime/reactivity/computations.ts

@@ -11,7 +11,10 @@ interface ComputedOptions<TWrite> {
   set?(value: TWrite): void;
 }
 
-export function computed<TRead, TWrite=TRead>(getter: () => TRead, options: ComputedOptions<TWrite> = {}): ReactiveValue<TRead, TWrite> {
+export function computed<TRead, TWrite = TRead>(
+  getter: () => TRead,
+  options: ComputedOptions<TWrite> = {}
+): ReactiveValue<TRead, TWrite> {
   const computation = createComputation({
     compute: () => {
       onWriteAtom(computation);

src/runtime/reactivity/computed.ts

@@ -100,7 +100,7 @@ exports[`basics render from above on error -- handler is not a Root or MountFibe
   let { text, createBlock, list, multi, html, toggler, comment } = bdom;
   const comp1 = app.createComponent(\`Parent\`, true, false, false, []);
 
-  return function template(ctx, node, key = \\"\\") {
+  return function template(ctx, node, key = "") {
     return comp1({}, key + \`__1\`, node, this, null);
   }
 }"
@@ -114,12 +114,12 @@ exports[`basics render from above on error -- handler is not a Root or MountFibe
 
   let block1 = createBlock(\`<div><block-child-0/><block-child-1/></div>\`);
 
-  return function template(ctx, node, key = \\"\\") {
+  return function template(ctx, node, key = "") {
     let b2, b3;
-    if (ctx['error']) {
+    if (ctx['this'].error) {
       b2 = text(\`Error\`);
     } else {
-      b3 = comp1({onError: (ctx['handleError']).bind(this)}, key + \`__1\`, node, this, null);
+      b3 = comp1({onError: (ctx['this'].handleError).bind(this)}, key + \`__1\`, node, this, null);
     }
     return block1([], [b2, b3]);
   }
@@ -130,12 +130,13 @@ exports[`basics render from above on error -- handler is not a Root or MountFibe
 "function anonymous(app, bdom, helpers
 ) {
   let { text, createBlock, list, multi, html, toggler, comment } = bdom;
+  let { safeOutput } = helpers;
 
-  let block1 = createBlock(\`<div><block-text-0/></div>\`);
+  let block1 = createBlock(\`<div><block-child-0/></div>\`);
 
-  return function template(ctx, node, key = \\"\\") {
-    let txt1 = ctx['a'].b.c;
-    return block1([txt1]);
+  return function template(ctx, node, key = "") {
+    const b2 = safeOutput(ctx['a'].b.c);
+    return block1([], [b2]);
   }
 }"
 `;

tests/components/__snapshots__/error_handling.test.ts.snap

@@ -1,4 +1,4 @@
-import { App, Component, mount, onWillDestroy, props } from "../../src";
+import { App, Component, mount, onWillDestroy, props, types } from "../../src";
 import { OwlError } from "../../src/common/owl_error";
 import {
   onError,
@@ -239,7 +239,8 @@ function(app, bdom, helpers) {
 
   test("render from above on error -- handler is not a Root or MountFiber", async () => {
     class Boom extends Component {
-      static template = xml`<div t-esc="a.b.c"/>`;
+      static template = xml`<div t-out="a.b.c"/>`;
+      props = props({ onError: types.function() });
       setup() {
         onError((err) => {
           this.props.onError(err);
@@ -250,9 +251,9 @@ function(app, bdom, helpers) {
     class Parent extends Component {
       static template = xml`
         <div>
-          <t t-if="error">Error</t>
+          <t t-if="this.error">Error</t>
           <t t-else="">
-            <Boom onError.bind="handleError"/>
+            <Boom onError.bind="this.handleError"/>
           </t>
         </div>`;
       static components = { Boom };
@@ -261,7 +262,7 @@ function(app, bdom, helpers) {
 
       handleError(err: Error) {
         this.error = err;
-        this.render();
+        render(this);
       }
     }
 

tests/components/error_handling.test.ts

@@ -391,21 +391,21 @@ describe("writable computed", () => {
     const value = signal(4);
     const binary = computed(() => value().toString(2), {
       set: (nextValue: string | number) => {
-        if(typeof nextValue === "number") {
-          value.set(nextValue)
+        if (typeof nextValue === "number") {
+          value.set(nextValue);
         } else {
-          value.set(parseInt(nextValue, 2))
+          value.set(parseInt(nextValue, 2));
         }
-      }
-    })
-    expect(binary()).toBe("100")
+      },
+    });
+    expect(binary()).toBe("100");
 
     // can set a string
-    binary.set("110")
-    expect(value()).toBe(6)
+    binary.set("110");
+    expect(value()).toBe(6);
 
     // can also set a number
-    binary.set(7)
-    expect(value()).toBe(7)
-  })
+    binary.set(7);
+    expect(value()).toBe(7);
+  });
 });