[vibe coding] [Enhancement]: delete the codes oracle related (#116) (#145)

Remove Oracle-related code from seekdb as it no longer supports Oracle
compatibility mode.

Changes:
- Remove ob_oracle_errno, ob_oracle_errno_with_check, ob_oracle_strerror,
  and ob_oracle_str_user_error function declarations from ob_errno.h
- Remove corresponding function definitions from ob_errno.cpp
- Modify ob_errpkt_* functions to only use MySQL error handling
- Update callers to use MySQL error functions instead of Oracle ones:
  - src/pl/ob_pl.cpp
  - src/sql/resolver/ddl/ob_create_view_resolver.cpp
  - src/observer/mysql/obmp_packet_sender.cpp
  - src/observer/mysql/obmp_stmt_prexecute.cpp
  - src/sql/engine/dml/ob_err_log_service.cpp
- Remove Oracle error support from tools/ob_error

Closes #116

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: zhangjiongai-debug

src/observer/mysql/obmp_packet_sender.cpp

@@ -371,8 +371,7 @@ int ObMPPacketSender::send_error_packet(int err,
   sql::ObSQLSessionInfo *session = NULL;
   BACKTRACE(ERROR, (OB_SUCCESS == err), "BUG send error packet but err code is 0");
   if (OB_ERR_PROXY_REROUTE != err) {
-    int client_error = lib::is_oracle_mode() ? common::ob_oracle_errno(err) :
-                      common::ob_mysql_errno(err);
+    int client_error = common::ob_mysql_errno(err);
     // OB error codes that are not compatible with mysql will be displayed using
     // OB error codes
     client_error = lib::is_mysql_mode() && client_error == -1 ? err : client_error;

src/observer/mysql/obmp_stmt_prexecute.cpp

@@ -1003,7 +1003,7 @@ int ObMPStmtPrexecute::response_fail_result(sql::ObSQLSessionInfo &session, int
   for (int64_t i = 2; i < (arraybinding_row_->get_count() - 1); i++) {
     arraybinding_row_->get_cell(i).set_null();
   }
-  arraybinding_row_->get_cell(arraybinding_row_->get_count() - 1).set_varchar(ob_oracle_strerror(err_ret));
+  arraybinding_row_->get_cell(arraybinding_row_->get_count() - 1).set_varchar(ob_strerror(err_ret));
   if (OB_FAIL(response_row(session, *arraybinding_row_, arraybinding_columns_, false))) {
     LOG_WARN("fail to response fail row to client", K(ret));
   }
@@ -1052,7 +1052,7 @@ int ObMPStmtPrexecute::response_returning_rows(ObSQLSessionInfo &session,
       for (int i = 0; i < result_row->get_count(); i++) {
         arraybinding_row_->get_cell(i+2).set_null();
       }
-      arraybinding_row_->get_cell(arraybinding_row_->get_count() - 1).set_varchar(ob_oracle_strerror(ret));
+      arraybinding_row_->get_cell(arraybinding_row_->get_count() - 1).set_varchar(ob_strerror(ret));
       LOG_DEBUG("error occured before send arraybinding_row_", KPC(arraybinding_row_));
       if (OB_SUCCESS != (response_ret = response_row(session, *arraybinding_row_, arraybinding_columns_, false, &result.get_exec_context()))) {
         LOG_WARN("fail to response row to client", K(response_ret));

src/pl/ob_pl.cpp

@@ -2718,7 +2718,7 @@ int ObPL::insert_error_msg(int errcode)
   if (err_txt.empty()) {
     ObWarningBuffer *wb = common::ob_get_tsi_warning_buffer();
     if (OB_NOT_NULL(wb)) {
-      wb->set_error(common::ob_oracle_strerror(errcode), errcode);
+      wb->set_error(common::ob_strerror(errcode), errcode);
     }
   }
   return ret;

src/share/ob_errno.cpp

@@ -36776,70 +36776,17 @@ int g_all_ob_errnos[2440] = {0, -4000, -4001, -4002, -4003, -4004, -4005, -4006,
     }
     return ret;
   }
-  const char *ob_oracle_strerror(const int err)
+  int ob_errpkt_errno(const int err, const bool /* is_oracle_mode - deprecated */)
   {
-    const char *ret = "Unknown error";
-    if (OB_LIKELY(0 >= err && err > -OB_MAX_ERROR_CODE)) {
-      if (!g_enable_ob_error_msg_style) {
-        ret = get_error(-err)->oracle_str_error;
-      } else {
-        ret = get_error(-err)->ob_str_error;
-      }
-      if (OB_UNLIKELY(NULL == ret || '\0' == ret[0]))
-      {
-        ret = "Unknown Error";
-      }
-    }
-    return ret;
-  }
-  const char *ob_oracle_str_user_error(const int err)
-  {
-    const char *ret = NULL;
-    if (OB_LIKELY(0 >= err && err > -OB_MAX_ERROR_CODE)) {
-      if (!g_enable_ob_error_msg_style) {
-        ret = get_error(-err)->oracle_str_user_error;
-      } else {
-        ret = get_error(-err)->ob_str_user_error;
-      }
-      if (OB_UNLIKELY(NULL == ret || '\0' == ret[0])) {
-        ret = NULL;
-      }
-    }
-    return ret;
-  }
-  int ob_oracle_errno(const int err)
-  {
-    int ret = -1;
-    if (OB_ERR_PROXY_REROUTE == err) {
-      // Oracle Mode and MySQL mode should return same errcode for reroute sql
-      // thus we make the specialization here
-      ret = -1;
-    } else if (err >= OB_MIN_RAISE_APPLICATION_ERROR && err <= OB_MAX_RAISE_APPLICATION_ERROR) {
-      ret = err; // PL/SQL Raise Application Error
-    } else if (OB_LIKELY(0 >= err && err > -OB_MAX_ERROR_CODE)) {
-      ret = get_error(-err)->oracle_errno;
-    }
-    return ret;
-  }
-  int ob_oracle_errno_with_check(const int err)
-  {
-    int ret = ob_oracle_errno(err);
-    if (ret < 0) {
-      ret = -err;
-    }
-    return ret;
-  }
-  int ob_errpkt_errno(const int err, const bool is_oracle_mode)
-  {
-    return (is_oracle_mode ? ob_oracle_errno_with_check(err) : ob_mysql_errno_with_check(err));
+    return ob_mysql_errno_with_check(err);
   }
-  const char *ob_errpkt_strerror(const int err, const bool is_oracle_mode)
+  const char *ob_errpkt_strerror(const int err, const bool /* is_oracle_mode - deprecated */)
   {
-    return (is_oracle_mode ? ob_oracle_strerror(err) : ob_strerror(err));
+    return ob_strerror(err);
   }
-  const char *ob_errpkt_str_user_error(const int err, const bool is_oracle_mode)
+  const char *ob_errpkt_str_user_error(const int err, const bool /* is_oracle_mode - deprecated */)
   {
-    return (is_oracle_mode ? ob_oracle_str_user_error(err) : ob_str_user_error(err));
+    return ob_str_user_error(err);
   }
 
 } // end namespace common

src/share/ob_errno.h

@@ -9351,14 +9351,9 @@ extern int g_all_ob_errnos[2440];
   const char *ob_strerror(const int oberr);
   const char *ob_str_user_error(const int oberr);
 
-  int ob_oracle_errno(const int oberr);
-  int ob_oracle_errno_with_check(const int oberr);
-  const char *ob_oracle_strerror(const int oberr);
-  const char *ob_oracle_str_user_error(const int oberr);
+  // Note: Oracle-related functions (ob_oracle_errno, ob_oracle_strerror, etc.) have been removed
+  // as seekdb no longer supports Oracle compatibility mode.
 
-#ifndef __ERROR_CODE_PARSER_
-  int get_ob_errno_from_oracle_errno(const int error_no, const char *error_msg, int &ob_errno);
-#endif
   int ob_errpkt_errno(const int oberr, const bool is_oracle_mode);
   const char *ob_errpkt_strerror(const int oberr, const bool is_oracle_mode);
   const char *ob_errpkt_str_user_error(const int oberr, const bool is_oracle_mode);

src/sql/engine/dml/ob_err_log_service.cpp

@@ -50,10 +50,10 @@ int ObErrLogService::gen_insert_sql_str(ObIAllocator &alloc,
   int64_t default_column_name_pos = 0;
   int64_t default_column_value_pos = 0;
 
-  const int err_no = ob_oracle_errno(first_err_ret);
+  const int err_no = ob_mysql_errno(first_err_ret);
   // ObString msg = ob_get_tsi_err_msg(first_err_ret);
   // Because there are escape characters in dynamic_msg, use static error messages now
-  ObString msg = ObString::make_string(ob_oracle_strerror(first_err_ret));
+  ObString msg = ObString::make_string(ob_strerror(first_err_ret));
 
   // %.*s 1:database_name
   // %.*s 2:table_name

src/sql/resolver/ddl/ob_create_view_resolver.cpp

@@ -436,7 +436,7 @@ int ObCreateViewResolver::try_add_error_info(const uint64_t error_number,
   if (ERROR_STATUS_HAS_ERROR == error_info.get_error_status()) {
     /* do nothing */
   } else {
-    ObString err_txt(common::ob_oracle_strerror(error_number));
+    ObString err_txt(common::ob_strerror(error_number));
     error_info.set_error_number(error_number);
     error_info.set_error_status(ERROR_STATUS_HAS_ERROR);
     if (err_txt.empty()) {

tools/ob_error/src/ob_error.cpp

@@ -210,54 +210,22 @@ void ObErrorInfoMgr::print_ob_error()
       is_compat_header_printed = true;
       printf("\t\tMySQL: %d(%s)\n", mysql_errno, sqlstate);
     }
-    bool need_oracle_print = false;
-    int oracle_errno = ob_errpkt_errno(ob_error_code, true);
-    if (oracle_errno != -ob_error_code) {
-      if (ORACLE_SPECIAL_ERROR_CODE == oracle_errno) {
-        // Compatible error for ORA-00600
-        if (is_special_oracle_error_compatible(ob_error_code)) {
-          need_oracle_print = true;
-        }
-      } else {
-        need_oracle_print = true;
-      }
-      if (need_oracle_print) {
-        const char *oracle_err_msg = ob_errpkt_strerror(ob_error_code, true);
-        if (nullptr != oracle_err_msg) {
-          if (false == is_compat_header_printed) {
-            printf("\t%s\n", compatiable_header);
-            is_compat_header_printed = true;
-          }
-          char oracle_error_code[ORACLE_MSG_PREFIX] = {0};
-          strncpy(oracle_error_code, oracle_err_msg, ORACLE_MSG_PREFIX-2);
-          printf("\t\tOracle: %s\n", oracle_error_code);
-        }
-      }
-    }
+    // Oracle error code printing removed - seekdb no longer supports Oracle compatibility mode
   }
 }
 //////////////////////////////////////////////////////////////
 static void print_help()
 {
   printf("This is the ob_error tool. Usage:\n\n"
          "    ob_error [option]\n"
-         "    ob_error [facility] error_code [-a ARGUMENT]\n"
-         "    ob_error [facility] error_code [--argument ARGUMENT]\n"
+         "    ob_error [facility] error_code\n"
          "Get the error information, reasons and possible solutions.\n\n"
          "Query an error:\n\n"
          "    ob_error error_code\n\n"
          "Query an error in MySQL mode:\n\n"
          "    ob_error MY error_code\n\n"
-         "Query an error in ORACLE mode:\n\n"
-         "    ob_error facility error_code\n"
-         "    ob_error facility error_code -a ARGUMENT\n"
-         "    ob_error facility error_code --argument ARGUMENT\n\n"
-         "ARGUMENT:         \n\n"
-         "  Positive number   OceanBase error_code in ORA-00600 error output.\n\n"
          "facility:\n\n"
-         "  MY                MySQL mode.\n"
-         "  ORA               ORACLE mode. Error from database.\n"
-         "  PLS               ORACLE mode. Error from the stored procedure.\n\n"
+         "  MY                MySQL mode.\n\n"
          "Normal options:\n\n"
          "  --help, -h        Print this message and then exit.\n"
          "  --version, -V     Print version information and then exit.\n\n");
@@ -473,74 +441,13 @@ bool add_mysql_info(int error_code, ObErrorInfoMgr* mgr)
 
 bool add_oracle_info(Fac oracle_facility, int error_code, int argument, ObErrorInfoMgr* mgr)
 {
-  bool bret = false;
-  if (nullptr == mgr) {
-    ERROR_PRINT("ObErrorInfoMgr *mgr is null.\n");
-    bret = true;
-  } else if (0 <= error_code && ORACLE_MAX_ERROR_CODE > error_code) {
-    int info_count = 0;
-    int ob_error = -1;
-    // Before being called, ensure that argument cannot be set when nullptr == oracle_facility
-    if (NONE == oracle_facility) {
-      // Handle the case where error is ORA-error_code
-      bret |= add_error_info(error_code, ORA, g_oracle_ora, mgr);
-      // Handle the case where error is PLS-error_code
-      bret |= add_error_info(error_code, PLS, g_oracle_pls, mgr);
-    } else {
-      if (ORA == oracle_facility) {
-        if (ORACLE_SPECIAL_ERROR_CODE == error_code) {
-          // 600 is a special error code.
-          // If there is no '-a ARG' parameter, the original possible error of ora-00600 will be output
-          if (-1 == argument) {
-            bret = add_error_info(error_code, ORA, g_oracle_ora, mgr);
-          } else {
-            ob_error = argument;
-            const char* error_usr_msg = ob_errpkt_str_user_error(-ob_error, true);
-            if (nullptr != error_usr_msg) {
-              // verify that the error is ora-00600
-              if (-OB_ERR_PROXY_REROUTE == ob_errpkt_errno(-ob_error, true) ||
-                  ORACLE_SPECIAL_ERROR_CODE == ob_errpkt_errno(-ob_error, true)) {
-                const char* error_msg = ob_errpkt_strerror(-ob_error, true);
-                const char* error_name = ob_error_name(-ob_error);
-                const char* error_cause = ob_error_cause(-ob_error);
-                const char* error_solution = ob_error_solution(-ob_error);
-                if (mgr->insert_oracle_error(error_name,
-                        error_msg + ORACLE_MSG_PREFIX,
-                        error_cause,
-                        error_solution,
-                        ORA,
-                        error_code,
-                        ob_error)) {
-                  bret = true;
-                }
-              }
-            }
-          }
-        } else {
-          // '-a ARG' parameter only supports ora-00600 error
-          if (-1 != argument) {
-            printf("error: '-a ARG' is unsupport in this scene\n"
-                   "Use 'ob_error ora 600 -a=ARG'.\n"
-                   "Use 'ob_error --help' for help.\n");
-            bret = true;
-          } else {
-            bret = add_error_info(error_code, ORA, g_oracle_ora, mgr);
-          }
-        }
-      } else if (PLS == oracle_facility) {
-        // '-a ARG' parameter only supports ora-00600 error
-        if (-1 != argument) {
-          printf("error: '-a ARG' is unsupport in this scene\n"
-                 "Use 'ob_error ora 600 -a ARG'.\n"
-                 "Use 'ob_error --help' for help.\n");
-          bret = true;
-        } else {
-          bret = add_error_info(error_code, PLS, g_oracle_pls, mgr);
-        }
-      }
-    }
-  }
-  return bret;
+  // Oracle support has been removed from seekdb
+  // This function now returns false to indicate no Oracle error info is available
+  (void)oracle_facility;
+  (void)error_code;
+  (void)argument;
+  (void)mgr;
+  return false;
 }
 
 // prevent the atoi parse "123abc"
@@ -777,24 +684,7 @@ static bool ob_init_error_to_oberror(int ora_err[][OB_MAX_SAME_ERROR_COUNT], int
         bret = false;
       }
     }
-    // init ora_err/pls_err map
-    const char* error_usr_msg = ob_oracle_str_user_error(-i);
-    error_code = ob_oracle_errno(-i);
-    if (-1 != error_code && NULL != error_usr_msg) {
-      if (0 > error_code)
-        error_code = -error_code;
-      if (0 == strncmp(error_usr_msg, facility_str[ORA], strlen(facility_str[ORA]))) {
-        if (!insert_oracle_error_slot_ora(ora_err, error_code, i)) {
-          ERROR_PRINT("error: OB_MAX_SAME_ERROR_COUNT is not enough for ORA-%05d(OB Error %d)\n", error_code, i);
-          bret = false;
-        }
-      } else if (0 == strncmp(error_usr_msg, facility_str[PLS], strlen(facility_str[PLS]))) {
-        if (!insert_oracle_error_slot_pls(pls_err, error_code, i)) {
-          ERROR_PRINT("error: OB_MAX_SAME_ERROR_COUNT is not enough for PLS-%05d(OB Error %d)\n", error_code, i);
-          bret = false;
-        }
-      }
-    }
+    // Oracle error mapping removed - seekdb no longer supports Oracle compatibility mode
   }
   return bret;
 }