ci: matrix introduced to ci and copr fix

* used matrix instead of duplicating steps
* reintroduced rpmlint to fix copr build

Signed-off-by: Jasper Berton <jasper.berton@team.blue>

Author: JasperB-TeamBlue

.copr/Makefile

@@ -2,7 +2,7 @@
 
 # requirements for automation/build.sh (see also ../ovirt-web-ui.spec.in)
 installdeps:
-	dnf -y install git jq rpm-build autoconf automake
+	dnf -y install git jq rpmlint rpm-build autoconf automake
 
 # explicity mark the copr generated git repo directory (which is done prior to the mock
 # call to the make_srpm and will be the current pwd) as safe for git commands

.github/workflows/check.yaml

@@ -9,64 +9,33 @@ on:
 
 jobs:
 
-  test_el9_offline:
-    name: EL9 (ovirt-engine-nodejs-modules build) - test, build and publish rpm repo for the PR
-    env:
-      OFFLINE_BUILD: 1
-
-    runs-on: ubuntu-latest
-    container:
-      image: quay.io/ovirt/buildcontainer:el9stream
-
-    steps:
-      - name: Checkout sources
-        uses: ovirt/checkout-action@main
-      
-      - name: install rpmlint
-        run: dnf -y install rpmlint
-
-      - name: Run automation/build.sh (installs build dependencies as necessary)
-        run: ./automation/build.sh
-
-      - name: Upload artifacts as rpm repo
-        uses: ovirt/upload-rpms-action@main
-        with:
-          directory: exported-artifacts/
-  
-  test_el9_online:
-    name: EL9 (online build) test and build the PR, but skip the rpm builds
+  test_offline:
     runs-on: ubuntu-latest
-    container:
-      image: quay.io/ovirt/buildcontainer:el9stream
-    steps:
-      - name: Install yarn (online mode does not use ovirt-engine-nodejs-modules so yarn isn't installed)
-        run: |
-          dnf -y config-manager --add-repo https://dl.yarnpkg.com/rpm/yarn.repo
-          dnf -y --disablerepo='*' --enablerepo='yarn*' install yarn
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: centos-stream9
+            container-name: el9stream
+          - name: centos-stream10
+            container-name: el10stream
 
-      - name: Checkout sources
-        uses: ovirt/checkout-action@main
+    name: ${{ matrix.name }} (ovirt-engine-nodejs-modules build) - test, build and publish rpm repo for the PR
 
-      - name: Run 'yarn install' and 'yarn build' (like a developer would)
-        run: |
-          yarn install
-          yarn build
-
-  test_el10_offline:
-    name: EL10 (ovirt-engine-nodejs-modules build) - test, build and publish rpm repo for the PR
     env:
       OFFLINE_BUILD: 1
 
-    runs-on: ubuntu-latest
     container:
-      image: quay.io/ovirt/buildcontainer:el10stream
+      image: quay.io/ovirt/buildcontainer:${{ matrix.container-name }}
 
     steps:
       - name: Checkout sources
         uses: ovirt/checkout-action@main
-
+      
       - name: install rpmlint
-        run: pip install rpmlint
+        run: |
+          dnf -y install epel-release
+          dnf -y install rpmlint
 
       - name: Run automation/build.sh (installs build dependencies as necessary)
         run: ./automation/build.sh
@@ -76,11 +45,22 @@ jobs:
         with:
           directory: exported-artifacts/
 
-  test_el10_online:
-    name: EL10 (online build) test and build the PR, but skip the rpm builds
+  test_online:
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: centos-stream9
+            container-name: el9stream
+          - name: centos-stream10
+            container-name: el10stream
+
+    name: ${{ matrix.name }} (online build) test and build the PR, but skip the rpm builds
+
     container:
-      image: quay.io/ovirt/buildcontainer:el10stream
+      image: quay.io/ovirt/buildcontainer:${{ matrix.container-name }}
+
     steps:
       - name: Install yarn (online mode does not use ovirt-engine-nodejs-modules so yarn isn't installed)
         run: |