`allowOther` removal leads to broken mounts

[LennyPenny]

Heyo,
I use both the nixos module and the home manager module since quite a while.

I recently updated and got deprecation errors about the home manager module being part of the nixos module and, more importantly, the allowOther option being removed.

My old hm setup is as follows:

{ ... }:
{
  home.persistence."/persist/backup/home" = {
    directories = [
      "Downloads"
      "Music"
      "Pictures"
      "Documents"
      "Videos"
      ...
    ];
    files = [ ];
    allowOther = true;
  };
  home.persistence."/persist/main/home" = {
    directories = [
      ".local/share/direnv"
      ".cache/nix-index"
    ];
    files = [ ];
    allowOther = true;
  };
}

The deprecation error makes it sound like I can just remove allowOther now, which I went ahead and did.

To my surprise this broke my setup. All the directories like /home/lenny/Downloads etc. now appear empty.

I went ahead an checked the systemd mount services and found that somehow some paths got duplicated and my username magically added.
Instead of /persist/backup/home/Downloads, it now created new empty directories at /persist/backup/home/home/lenny/Downloads and mounts those instead.

I'm a bit lost as I have no idea where that extra path stuff in coming from, do I need to to make any other changes to my config?

[nakoo]

With the recent change, old home.persistence."/persistence/${home.homeDirectory}" became home.persistence."/persistence".

[LennyPenny]

But I didn't use "/persistence/${home.homeDirectory}.

Do I need to manually move my files to /persist/backup/home/<myusername>/ now with this change as it's always included and not removable?

[GustawXYZ]

Thanks @nakoo, that helped me figure this out, as I was also surprised by this.

@LennyPenny For me what did it is in my config I had:
home.persistence."/persist/home" and all my things were in there like so /persist/home/Documents.
I changed that to home.persistence."/persist" and moved all my stuff mv /persist/home/* /persist/home/<username> (simplification, since it will not move .* files and will error on moving /persist/home/<username> to /persist/home/<username>.)

After that I ran nh os boot, rebooted and everything is working again.