Crash on `organizeDeclarations`

[BastiOSDev]

Hey Nick,

thanks for your work on this project! I implemented SwiftFormat to an old project of mine and registered an crash on the organizeDeclarations rule with the following code.

Do you mind to take a look on this crash?

struct MultiSelectMenu<Choice: Identifiable & Hashable>: View {

    let title: String
    let systemImage: String

    let all: [Choice]
    @Binding var selected: [Choice]

    let titleProvider: (Choice) -> String
    let colorProvider: (Choice) -> Color

    init(
        title: String,
        systemImage: String = "person.circle.fill",
        all: [Choice],
        selected: Binding<[Choice]>,
        titleProvider: @escaping (Choice) -> String,
        colorProvider: @escaping (Choice) -> Color
    ) {
        self.title = title
        self.systemImage = systemImage
        self.all = all
        self._selected = selected
        self.titleProvider = titleProvider
        self.colorProvider = colorProvider
    }

    var body: some View {
        Menu {
            ForEach(all) { item in
                let isOn = selected.contains(where: { $0.id == item.id })
                Button {
                    toggle(item)
                } label: {
                    HStack {
                        Text(titleProvider(item))
                        Spacer()
                        if isOn {
                            Image(systemName: "checkmark")
                        }
                    }
                }
            }

            if !selected.isEmpty {
                Divider()
                Button("Clear Selection", role: .destructive) {
                    selected.removeAll()
                }
            }
        } label: {
            HStack(spacing: 8) {
                Image(systemName: systemImage)
                    .imageScale(.medium)

                Text(title)
                Spacer()
                if !selected.isEmpty {
                    SelectedChips(
                        selected: selected,
                        titleProvider: titleProvider,
                        colorProvider: colorProvider
                    )
                    .padding(.trailing, 2)
                }
            }
            .foregroundStyle(.primary)
            .tint(.primary)
        }
        .frame(minHeight: 22)
    }

    private func toggle(_ item: Choice) {
        if let idx = selected.firstIndex(where: { $0.id == item.id }) {
            selected.remove(at: idx)
        } else {
            selected.append(item)
        }
    }

    // MARK: - Chips View

    private struct SelectedChips: View {
        let selected: [Choice]
        let titleProvider: (Choice) -> String
        let colorProvider: (Choice) -> Color

        var body: some View {
            let maxChips = 3
            let head = Array(selected.prefix(maxChips))
            let restCount = max(0, selected.count - maxChips)

            HStack(spacing: 6) {
                ForEach(head, id: \.id) { item in
                    let text = initials(for: titleProvider(item))
                    let color = colorProvider(item)
                    UserView(
                        title: text,
                        backgroundColor: color,
                        style: .iconOnly,
                        frame: 22,
                        iconFont: .caption2.bold()
                    )
                }

                if restCount > 0 {
                    Text("+ \(restCount)")
                        .font(.caption).bold()
                        .padding(.horizontal, 6).padding(.vertical, 2)
                        .background(
                            RoundedRectangle(cornerRadius: 6)
                                .stroke(.secondary, lineWidth: 1)
                        )
                }
            }
            .accessibilityLabel("\(selected.count) selected")
        }

        private func initials(for name: String) -> String {
            let parts = name.split(separator: " ")
            let first = parts.first?.first.map(String.init) ?? ""
            let last = parts.dropFirst().first?.first.map(String.init) ?? ""
            return (first + last).uppercased()
        }
    }
}

[calda]

Having trouble reproducing the issue. Could you share the SwiftFormat command invocation + config file you're using?

[BastiOSDev]

Sure. I just use the terminal for this, with swiftformat . on the root folder of the project. Here the output of that (**** is the censorship for the path):

swiftformat .  
Running SwiftFormat...
Reading config file at /****/.swiftformat
Reading swift-version file at /****/.swift-version (version 6.2)
zsh: trace trap  swiftformat .

With // swiftformat:disable organizeDeclarations in front of the struct swiftformat runs successfully.

The installed version of swiftformat is 0.60.1

Due to github the .swiftformat file is not supported to add, so here are the contents:

# File options

--exclude DerivedData

# Disable all rules to avoid new rules on Swiftformat updates

--disable all

## For more rules, details and examples for them see:

## https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md

## Enabled rules (##--enable ...) are sometimes followed by options for them (##--optionName ...)

# Prefer comma over && in if, guard or while conditions.

--enable andOperator

# Replace obsolete @UIApplicationMain and @NSApplicationMain attributes with @main for Swift 5.3 and above.

--enable applicationMain

# Changes all instances of assert(false, ...) to assertionFailure(...) and precondition(false, ...) to preconditionFailure(...).

--enable assertionFailures

# Insert blank line after import statements.

--enable blankLineAfterImports

# Insert a blank line after multiline switch cases (excluding the last case, which is followed by a closing brace).

--enable blankLineAfterSwitchCase

# Insert blank line before and after MARK: comments.

--enable blankLinesAroundMark

# Insert blank line after "MARK:": "true" (default) or "false"

--lineaftermarks true

# Remove trailing blank line at the end of a scope.

--enable blankLinesAtEndOfScope

# Remove leading blank line at the start of a scope.

--enable blankLinesAtStartOfScope

# "remove" (default) or "preserve" blank lines from types

--typeblanklines remove

# Remove blank lines between chained functions but keep the linebreaks.

--enable blankLinesBetweenChainedFunctions

# Insert blank line before class, struct, enum, extension, protocol or function declarations.

--enable blankLinesBetweenScopes

# Wrap braces in accordance with selected style (K&R or Allman).

--enable braces

# Use allman indentation style: "true" or "false" (default)

--allman false

# Assign properties using if / switch expressions.

--enable conditionalAssignment

# Use cond. assignment: "after-property" (default) or "always"

--condassignment after-property

# Replace consecutive blank lines with a single blank line.

--enable consecutiveBlankLines

# Replace consecutive spaces with a single space.

--enable consecutiveSpaces

# Ensures consistent spacing among all of the cases in a switch statement.

--enable consistentSwitchCaseSpacing

# Use doc comments for API declarations, otherwise use regular comments.

--enable docComments

# Doc comments: "before-declarations" (default) or "preserve"

--doccomments before-declarations

# Remove duplicate import statements.

--enable duplicateImports

# Place else, catch or while keyword in accordance with current style (same or next line).

--enable elseOnSameLine

# Placement of else/catch: "same-line" (default) or "next-line"

--elseposition same-line

# Guard else: "same-line", "next-line" or "auto" (default)

--guardelse auto

# Remove whitespace inside empty braces.

--enable emptyBraces

# Empty braces: "no-space" (default), "spaced" or "linebreak"

--emptybraces no-space

# Convert types used for hosting only static members into enums (an empty enum is the canonical way to create a namespace in Swift as it can't be instantiated).

--enable enumNamespaces

# Change type to enum: "always" (default) or "structs-only"

--enumnamespaces always

# Configure the placement of an extension's access control keyword.

--enable extensionAccessControl

# Place ACL "on-extension" (default) or "on-declarations"

--extensionacl on-extension

# Use specified source file header template for all files.

#--enable fileHeader

# Header comments: "strip", "ignore", or the text you wish use

#--header Copyright © 2025 JAKALA Germany GmbH. All rights reserved.

# Move inline await keyword(s) to start of expression.

--enable hoistAwait

# Reposition let or var bindings within pattern.

--enable hoistPatternLet

# let/var placement in patterns: "hoist" (default) or "inline"

--patternlet hoist

# Move inline try keyword(s) to start of expression.

--enable hoistTry

# List of functions with throwing @autoclosure arguments

--throwcapturing

# Indent code in accordance with the scope level.

--enable indent

# #if indenting: "indent" (default), "no-indent" or "outdent"

--ifdef no-indent

# Match Xcode indenting: "enabled" or "disabled" (default)

--xcodeindentation enabled

# Add @available(\*, unavailable) attribute to required init(coder:) when it hasn't been implemented.

--enable initCoderUnavailable

# Prefer isEmpty over comparing count against zero.

--enable isEmpty

# Move leading delimiters to the end of the previous line.

--enable leadingDelimiters

# Add empty blank line at end of file.

--enable linebreakAtEndOfFile

# Add a MARK comment before top-level types and extensions.

--enable markTypes

# Mark types "always" (default), "never", "if-not-empty"

--marktypes always

# Template for type mark comments. Defaults to "MARK: - %t"

--typemark MARK: - %t

# Mark extensions "always" (default), "never", "if-not-empty"

--markextensions never

# Mark for standalone extensions. Defaults to "MARK: - %t + %c"

--extensionmark MARK: - %t + %c

# Mark for extension grouped with extended type. ("MARK: %c")

--groupedextension MARK: - %c

# Use consistent ordering for member modifiers.

--enable modifierOrder

# Comma-delimited list of modifiers in preferred order

# If not see defaults to: see https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#modifierorder

#--modifierorder

# Use consistent grouping for numeric literals. Groups will be separated by \_ delimiters to improve readability. For each numeric type you can specify a group size (the number of digits in each group) and a threshold (the minimum number of digits in a number before grouping is applied).

--enable numberFormatting

# Decimal grouping,threshold (default: 3,6) or "none", "ignore"

--decimalgrouping 3,6

# Binary grouping,threshold (default: 4,8) or "none", "ignore"

--binarygrouping 4,8

# Octal grouping,threshold (default: 4,8) or "none", "ignore"

--octalgrouping 4,8

# Hex grouping,threshold (default: 4,8) or "none", "ignore"

--hexgrouping 4,8

# Group digits after '.': "enabled" or "disabled" (default)

--fractiongrouping disabled

# Group exponent digits: "enabled" or "disabled" (default)

--exponentgrouping disabled

# Casing for hex literals: "uppercase" (default) or "lowercase"

--hexliteralcase uppercase

# Case of 'e' in numbers: "lowercase" or "uppercase" (default)

--exponentcase uppercase

# Use opaque generic parameters (some Protocol) instead of generic parameters with constraints (T where T: Protocol, etc) where equivalent. Also supports primary associated types for common standard library types, so definitions like T where T: Collection, T.Element == Foo are updated to some Collection<Foo>.

--enable opaqueGenericParameters

# Use some Any types: "true" (default) or "false"

--someany false

# Organize declarations within class, struct, enum, actor, and extension bodies. (see: https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#organizedeclarations)

--enable organizeDeclarations

# Template for category mark comments. Defaults to "MARK: %c"

--categorymark MARK: %c

# Insert MARK comments between categories (true by default)

--markcategories true

# List of Declarations placed before first mark (e.g. typealias,struct)

--beforemarks

# Names of additional Lifecycle methods (e.g. viewDidLoad)

--lifecycle

# List of Declarations to organize (default: class,actor,struct,enum)

--organizetypes class,actor,struct,enum

# Minimum line count to organize struct body. Defaults to 0

--structthreshold 0

# Minimum line count to organize class body. Defaults to 0

--classthreshold 0

# Minimum line count to organize enum body. Defaults to 0

--enumthreshold 0

# Minimum line count to organize extension body. Defaults to 0

--extensionlength 0

# Organize declarations by "visibility" (default) or "type"

--organizationmode type

# Convert functional forEach calls to for loops.

--enable preferForLoop

# Convert anonymous forEach: "convert" (default) or "ignore"

--anonymousforeach convert

# Convert one-line forEach: "convert" or "ignore" (default)

--onelineforeach ignore

# Convert trivial map { $0.foo } closures to keyPath-based syntax map(\.foo).

--enable preferKeyPath

# Remove redundant backticks around identifiers.

--enable redundantBackticks

# Remove redundant break in switch case.

--enable redundantBreak

# Removes redundant closures bodies, containing a single statement, which are called immediately.

--enable redundantClosure

# Remove redundant access control modifiers.

--enable redundantExtensionACL

# Prefer private over fileprivate where equivalent.

--enable redundantFileprivate

# Remove unneeded get clause inside computed properties.

--enable redundantGet

# Remove explicit init if not required.

--enable redundantInit

# Remove redundant internal access control.

--enable redundantInternal

# Remove redundant let/var from ignored variables.

--enable redundantLet

# Remove redundant let error from catch clause.

--enable redundantLetError

# Remove/insert redundant nil default value (Optional vars are nil by default).

--enable redundantNilInit

# "remove" (default) redundant nil or "insert" missing nil

--nilinit remove

# Remove redundant @objc annotations.

--enable redundantObjc

# Remove redundant identifiers in optional binding conditions.

--enable redundantOptionalBinding

# Remove redundant parentheses.

--enable redundantParens

# Remove redundant pattern matching parameter syntax.

--enable redundantPattern

# Simplifies redundant property definitions that are immediately returned.

--enable redundantVariable

# Remove redundant raw string values for enum cases.

--enable redundantRawValues

# Remove unneeded return keyword.

--enable redundantReturn

# Remove explicit Self where applicable.

--enable redundantStaticSelf

# Remove redundant type from variable declarations.

--enable redundantType

# "inferred", "explicit", or "infer-locals-only" (default)

--redundanttype infer-locals-only

# Converts throws(any Error) to throws, and converts throws(Never) to non-throwing.

--enable redundantTypedThrows

# Remove explicit Void return type.

--enable redundantVoidReturnType

# Closure void returns: "remove" (default) or "preserve"

--closurevoid remove

# Remove semicolons.

--enable semicolons

# Allow semicolons: "never" or "inline" (default)

--semicolons inline

# Sort import statements alphabetically.

--enable sortImports

# "testable-first/last", "alpha" (default) or "length"

--importgrouping alpha

# Sort switch cases alphabetically.

--enable sortSwitchCases

# Sort protocol composition typealiases alphabetically.

--enable sortTypealiases

# Add or remove space around curly braces.

--enable spaceAroundBraces

# Add or remove space around square brackets.

--enable spaceAroundBrackets

# Add space before and/or after comments.

--enable spaceAroundComments

# Remove space around angle brackets.

--enable spaceAroundGenerics

# Add or remove space around operators or delimiters.

--enable spaceAroundOperators

# Spacing for operator funcs: "spaced" (default) or "no-space"

--operatorfunc spaced

# Comma-delimited list of operators without surrounding space

--nospaceoperators

# Spacing for ranges: "spaced" (default) or "no-space"

--ranges spaced

# "space-after" (default), "spaced" or "no-space"

--typedelimiter space-after

# Add or remove space around parentheses.

--enable spaceAroundParens

# Add space inside curly braces.

--enable spaceInsideBraces

# Remove space inside square brackets.

--enable spaceInsideBrackets

# Add leading and/or trailing space inside comments.

--enable spaceInsideComments

# Remove space inside angle brackets.

--enable spaceInsideGenerics

# Remove space inside parentheses.

--enable spaceInsideParens

# Remove backticks around self in Optional unwrap expressions.

--enable strongifiedSelf

# Use correct formatting for TODO:, MARK: or FIXME: comments.

--enable todos

# Use trailing closure syntax where applicable.

--enable trailingClosures

# Comma-delimited list of functions that use trailing closures

###--trailingclosures

# List of functions that should never use trailing closures

###--nevertrailing

# Add or remove trailing comma from the last item in a collection literal.

##--enable trailingCommas

# Commas in collection literals: "always" (default) or "inline"

##--commas inline

# Remove trailing space at end of a line.

--enable trailingSpace

# Trim trailing space: "always" (default) or "nonblank-lines"

--trimwhitespace always

# Prefer shorthand syntax for Arrays, Dictionaries and Optionals.

--enable typeSugar

# Use ? for optionals "always" or "except-properties" (default)

--shortoptionals always

# Mark unused function arguments with \_.

--enable unusedArguments

# "closure-only", "unnamed-only" or "always" (default)

--stripunusedargs closure-only

# Use Void for type declarations and () for values.

--enable void

# How void types are represented: "void" (default) or "tuple"

--voidtype void

# Wrap lines that exceed the specified maximum width.

--enable wrap

# Maximum length of a line before wrapping. defaults to "none"

--maxwidth 140

# Comma-delimited list of operators that shouldn't be wrapped

--nowrapoperators

# Color/image literal width. "actual-width" or "visual-width"

--assetliterals visual-width

# Wrap ternary operators: "default", "before-operators"

--wrapternary default

# Align wrapped function arguments or collection elements.

--enable wrapArguments

# Wrap all arguments: "before-first", "after-first", "preserve"

--wraparguments before-first

# Wrap func params: "before-first", "after-first", "preserve"

--wrapparameters before-first

# Wrap array/dict: "before-first", "after-first", "preserve"

--wrapcollections before-first

# Closing paren position: "balanced" (default) or "same-line"

--closingparen balanced

# Closing paren at call sites: "balanced" or "same-line"

--callsiteparen balanced

# Wrap return type: "if-multiline", "preserve" (default)

--wrapreturntype preserve

# Wrap conditions: "before-first", "after-first", "preserve"

--wrapconditions after-first

# Wrap typealiases: "before-first", "after-first", "preserve"

--wraptypealiases after-first

# Wrap effects: "if-multiline", "never", "preserve"

--wrapeffects never

# Wrap @attributes onto a separate line, or keep them on the same line.

--enable wrapAttributes

# Function @attributes: "preserve", "prev-line", or "same-line"

--funcattributes prev-line

# Type @attributes: "preserve", "prev-line", or "same-line"

--typeattributes prev-line

# Stored var @attribs: "preserve", "prev-line", or "same-line"

--storedvarattrs same-line

# Computed var @attribs: "preserve", "prev-line", "same-line"

--computedvarattrs prev-line

# Complex @attributes: "preserve", "prev-line", or "same-line"

--complexattrs prev-line

# List of @attributes to exclude from complexattrs rule

--noncomplexattrs

# Rewrite comma-delimited enum cases to one case per line.

--enable wrapEnumCases

# Wrap enum cases: "always" (default) or "with-values"

--wrapenumcases with-values

# Wrap single line // comments that exceed the specified ##--maxwidth (from 'wrap' rule).

--enable wrapSingleLineComments

# Prefer constant values to be on the right-hand-side of expressions.

--enable yodaConditions

# Swap yoda values: "always" (default) or "literals-only"

--yodaswap always

--typeBodyMarks remove

[BastiOSDev]

@calda I've found out what the crash produced. I'm sorry, I've cut out the most important part with the example. There was a // TODO: check code below in the line of the struct declaration (what I thought was not needed for you to reproduce).

struct MultiSelectMenu<Choice: Identifiable & Hashable>: View { // TODO: check code below

But without that swiftformat runs successfully. With that TODO the crash happens. Here are the files (if you need them). Do you mind to take a short look again?

SwiftFormatTest.zip