Use of `object-rewrite`

[philipc]

Hi,

I've become aware of this crate via an issue in the object crate. While looking into that issue, I noticed you have copies of object-rewrite code in src/elf/rewriter/elf.rs and src/elf/rewriter/writer.rs. This is fine, and the license allows that, but could you please add appropriate license attribution (or point me to it if I've missed it)?

More generally, the goals of this crate seem to overlap with object-rewrite. I see you originally started using it. I'd be interested to know what issues led you away from using it directly.

The fix for the object issue will likely involve changes to code that originated from object-rewrite. Ideally, I'd like to see fixes benefit both projects, which is much easier if object-rewrite is used directly instead of copying it. For the same reason, if you'd like help from me with fixing this, I'm more likely to do that fix in object-rewrite instead of here.

Thanks, and happy to discuss options.

[nichmor]

hey @philipc ! Thanks for raising this issue!

I don't remember exactly the specifics of why I've vendored object-rewrite parts ( or it was something missing from there which I wanted to upstream later, or some structs weren't public, so I couldn't use them, I need to try to remember why).

I'm very happy to switch back to it and point to the license attribution.

I will do the first license attribution and will start moving to the object-rewrite crate ( or start contributing upstream what it's missing there )

[nichmor]

also happy to help with the fix :)

[philipc]

Thanks for the attribution.

I'd be delighted to receive upstream contributions of things that are missing.

A major feature that object-rewrite is missing is Mach-O support. It's something I would like added, and I tried to design the API to support it, but I haven't made a start on it. The biggest blocker is that it needs a builder API in object, similar to the one for ELF.

[nichmor]

hey @philipc! made a first one here: gimli-rs/object#844