Skip to content

Commit 0da5cc8

Browse files
Simplify declaration of a namespace's standard resource sources
1 parent a82767f commit 0da5cc8

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

ng-appserver/src/main/java/ng/appserver/NGApplication.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -577,23 +577,26 @@ public NGSession createSessionForRequest( NGRequest request ) {
577577
private static void addDefaultResourceSources( final NGResourceManager resourceManager ) {
578578
final NGResourceLoader loader = resourceManager.resourceLoader();
579579

580-
// FIXME: These are the "unnamespaced" resource locations we started out with. They'll still work fine, but we'll need to consider their future // Hugi 2024-06-19
580+
// FIXME: These are the "unnamespaced" resource locations we started out with. They'll still work fine, but we'll need to consider their future and should probably be deleted // Hugi 2024-06-19
581581
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.App, new JavaClasspathResourceSource( "app-resources" ) );
582582
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.WebServer, new JavaClasspathResourceSource( "webserver-resources" ) );
583583
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.Public, new JavaClasspathResourceSource( "public" ) );
584584
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.ComponentTemplate, new JavaClasspathResourceSource( "components" ) );
585585

586-
// "app" namespace defined
587-
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.App, new JavaClasspathResourceSource( "ng/app/app-resources" ) );
588-
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.WebServer, new JavaClasspathResourceSource( "ng/app/webserver-resources" ) );
589-
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.Public, new JavaClasspathResourceSource( "ng/app/public" ) );
590-
loader.addResourceSource( StandardNamespace.App.identifier(), StandardResourceType.ComponentTemplate, new JavaClasspathResourceSource( "ng/app/components" ) );
591-
592-
// "ng" namespace defined
593-
loader.addResourceSource( StandardNamespace.NG.identifier(), StandardResourceType.App, new JavaClasspathResourceSource( "ng/ng/app-resources" ) );
594-
loader.addResourceSource( StandardNamespace.NG.identifier(), StandardResourceType.WebServer, new JavaClasspathResourceSource( "ng/ng/webserver-resources" ) );
595-
loader.addResourceSource( StandardNamespace.NG.identifier(), StandardResourceType.Public, new JavaClasspathResourceSource( "ng/ng/public" ) );
596-
loader.addResourceSource( StandardNamespace.NG.identifier(), StandardResourceType.ComponentTemplate, new JavaClasspathResourceSource( "ng/ng/components" ) );
586+
addDefaultResourcesourcesForNamespace( loader, StandardNamespace.App );
587+
addDefaultResourcesourcesForNamespace( loader, StandardNamespace.NG );
588+
}
589+
590+
/**
591+
* Declare resource sources for the standard resource types in the given namespace
592+
*/
593+
private static void addDefaultResourcesourcesForNamespace( final NGResourceLoader loader, final StandardNamespace namespace ) {
594+
final String id = namespace.identifier();
595+
596+
loader.addResourceSource( id, StandardResourceType.App, new JavaClasspathResourceSource( "ng/%s/app-resources".formatted( id ) ) );
597+
loader.addResourceSource( id, StandardResourceType.WebServer, new JavaClasspathResourceSource( "ng/%s/webserver-resources".formatted( id ) ) );
598+
loader.addResourceSource( id, StandardResourceType.Public, new JavaClasspathResourceSource( "ng/%s/public".formatted( id ) ) );
599+
loader.addResourceSource( id, StandardResourceType.ComponentTemplate, new JavaClasspathResourceSource( "ng/%s/components".formatted( id ) ) );
597600
}
598601

599602
/**

0 commit comments

Comments
 (0)