Skip to content

Commit d2a5045

Browse files
committed
Remove scale field
1 parent 00aca13 commit d2a5045

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

docs/proposals/rate-limiting.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -200,18 +200,6 @@ type RateLimitRule struct {
200200
// +kubebuilder:validation:Minimum=400
201201
// +kubebuilder:validation:Maximum=599
202202
RejectCode *int32 `json:"rejectCode,omitempty"`
203-
204-
// Scale enables a constant rate-limit by dividing the configured rate by the number of NGINX
205-
// replicas for a Gateway. This adjustment ensures that the rate-limit remains consistent,
206-
// even as the number of NGINX replicas fluctuates due to autoscaling. NGINX pods belonging to a separate Gateway
207-
// will not have an affect on the calculated rate. This will not work properly if requests
208-
// from a client are not evenly distributed across all NGINX pods (Such as with sticky sessions, long
209-
// lived TCP Connections with many requests, and so forth).
210-
//
211-
// Default: false
212-
//
213-
// +optional
214-
Scale *bool `json:"scale,omitempty"`
215203
}
216204

217205
// Size is a string value representing a size. Size can be specified in bytes, kilobytes (k), megabytes (m).
@@ -346,7 +334,6 @@ spec:
346334
dryRun: false
347335
logLevel: error
348336
rejectCode: 503
349-
scale: false
350337
status:
351338
ancestors:
352339
- ancestorRef:
@@ -393,7 +380,6 @@ spec:
393380
dryRun: false
394381
logLevel: error
395382
rejectCode: 503
396-
scale: true
397383
```
398384

399385
## Attachment and Inheritance
@@ -461,6 +447,7 @@ Key validation rules:
461447

462448
- Add support for global rate limiting. In NGINX Plus, this can be done by using the `ngx_stream_zone_sync_module` to extend the solution for Local Rate Limiting and provide a way for synchronizing contents of shared memory zones across NGINX Plus instances. Support for `zone_sync` is a separate enhancement and can either be completed along side global rate limiting support or separately.
463449
- Add Conditional Rate Limiting. Users would also like to set conditions for a rate limit policy, where if a certain condition isn't met, the request would either go to a default rate limit policy, or would not be rate limited. This is designed to be used in combination with one or more rate limit policies. For example, multiple rate limit policies with that condition on JWT level can be used to apply different tiers of rate limit based on the value of a JWT claim (ie. more req/s for a higher level, less req/s for a lower level).
450+
- Add some sort of Scale field for local rate limiting. This would dynamically calculate the rate of a `RateLimitPolicy` based on number of NGINX replicas.
464451

465452
## References
466453

0 commit comments

Comments
 (0)